RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-26 07:43:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent skin editor crash when scaling 0 area drawables

Browse Source 
Some skinnable drawables can have 0 width or height in certain
cases, leading to division by 0 and a crash when the position is
updated.
This commit is contained in:
kamp 2021-05-24 21:36:42 +02:00
parent 6263ebf9da
commit 65649e5a62
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Skinning/Editor/SkinSelectionHandler.cs
View File

@ -59,6 +59,10 @@ namespace osu.Game.Skinning.Editor
// the selection quad is always upright, so use an AABB rect to make mutating the values easier. // the selection quad is always upright, so use an AABB rect to make mutating the values easier.
var selectionRect = getSelectionQuad().AABBFloat; var selectionRect = getSelectionQuad().AABBFloat;
// If the selection has no area we cannot scale it
if (selectionRect.Area == 0.0)
return false;
// copy to mutate, as we will need to compare to the original later on. // copy to mutate, as we will need to compare to the original later on.
var adjustedRect = selectionRect; var adjustedRect = selectionRect;