RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-17 02:47:19 +00:00
Code Issues Packages Projects Releases Wiki Activity

Rewrite catch combo counter hide logic

Browse Source
This commit is contained in:
Salman Ahmed 2021-05-30 14:20:03 +03:00
parent fb81e5133f
commit 60b781701f
1 changed files with 3 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
osu.Game.Rulesets.Catch/Skinning/Legacy/CatchLegacySkinTransformer.cs
View File

@ -29,20 +29,17 @@ namespace osu.Game.Rulesets.Catch.Skinning.Legacy
switch (targetComponent.Target) switch (targetComponent.Target)
{ {
case SkinnableTarget.MainHUDComponents: case SkinnableTarget.MainHUDComponents:
if (!providesComboCounter) var components = Source.GetDrawableComponent(component) as SkinnableTargetComponentsContainer;
break;
if (Source.GetDrawableComponent(component) is SkinnableTargetComponentsContainer components) if (providesComboCounter && components != null)
{ {
// catch may provide its own combo counter; hide the default. // catch may provide its own combo counter; hide the default.
// todo: this should be done in an elegant way per ruleset, defining which HUD skin components should be displayed. // todo: this should be done in an elegant way per ruleset, defining which HUD skin components should be displayed.
foreach (var legacyComboCounter in components.OfType<LegacyComboCounter>()) foreach (var legacyComboCounter in components.OfType<LegacyComboCounter>())
legacyComboCounter.ContentVisible = false; legacyComboCounter.ContentVisible = false;
return components;
} }
break; return components;
} }
} }