RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-19 11:56:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

Prevent ValueChanged binds to external bindable

Browse Source
This commit is contained in:
smoogipoo 2020-09-02 21:44:07 +09:00
parent d363a5d164
commit 5ebead2bfd
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Screens/Select/FilterControl.cs
View File

@ -204,6 +204,7 @@ namespace osu.Game.Screens.Select
private class CollectionFilterDropdown : OsuDropdown<CollectionFilter>
{
private readonly IBindableList<BeatmapCollection> collections = new BindableList<BeatmapCollection>();
private readonly IBindableList<BeatmapInfo> beatmaps = new BindableList<BeatmapInfo>();
private readonly BindableList<CollectionFilter> filters = new BindableList<CollectionFilter>();
public CollectionFilterDropdown()
@ -223,7 +224,8 @@ namespace osu.Game.Screens.Select
{
base.LoadComplete();
Current.BindValueChanged(filterChanged);
beatmaps.CollectionChanged += filterBeatmapsChanged;
Current.BindValueChanged(filterChanged, true);
}
/// <summary>
@ -246,10 +248,10 @@ namespace osu.Game.Screens.Select
private void filterChanged(ValueChangedEvent<CollectionFilter> filter)
{
if (filter.OldValue?.Collection != null)
filter.OldValue.Collection.Beatmaps.CollectionChanged -= filterBeatmapsChanged;
beatmaps.UnbindFrom(filter.OldValue.Collection.Beatmaps);
if (filter.NewValue?.Collection != null)
filter.NewValue.Collection.Beatmaps.CollectionChanged += filterBeatmapsChanged;
beatmaps.BindTo(filter.NewValue.Collection.Beatmaps);
}
/// <summary>