From 5dabc9282c0e1e3be5538cd4c7996d67eae6197e Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Bart=C5=82omiej=20Dach?= <dach.bartlomiej@gmail.com>
Date: Sun, 13 Feb 2022 19:04:11 +0100
Subject: [PATCH] Change `BeatmapInfo` copy logic to be opt-in rather than
 opt-out

---
 osu.Game/Beatmaps/BeatmapManager.cs | 29 ++++++++++++++++++++++-------
 1 file changed, 22 insertions(+), 7 deletions(-)

diff --git a/osu.Game/Beatmaps/BeatmapManager.cs b/osu.Game/Beatmaps/BeatmapManager.cs
index 4fa07ff518..4dd0e08dab 100644
--- a/osu.Game/Beatmaps/BeatmapManager.cs
+++ b/osu.Game/Beatmaps/BeatmapManager.cs
@@ -131,13 +131,28 @@ namespace osu.Game.Beatmaps
             else
             {
                 newBeatmap = referenceBeatmap.Clone();
-                newBeatmap.BeatmapInfo = newBeatmapInfo = referenceBeatmap.BeatmapInfo.Clone();
-                // assign a new ID to the clone.
-                newBeatmapInfo.ID = Guid.NewGuid();
-                // clear difficulty name to avoid clashes on save.
-                newBeatmapInfo.DifficultyName = string.Empty;
-                // also clear the hash, as that's what is used to match .osu files with their corresponding realm beatmaps.
-                newBeatmapInfo.Hash = string.Empty;
+
+                var referenceBeatmapInfo = referenceBeatmap.BeatmapInfo;
+                newBeatmap.BeatmapInfo = newBeatmapInfo = new BeatmapInfo(referenceBeatmapInfo.Ruleset, referenceBeatmapInfo.Difficulty.Clone(), referenceBeatmapInfo.Metadata.DeepClone())
+                {
+                    // Only selected appropriate properties are copied over.
+                    // Things like database ID, online status/ID, MD5 hash, star rating, etc. are omitted
+                    // because they should not be copied over and/or they will be recomputed on save.
+                    AudioLeadIn = referenceBeatmapInfo.AudioLeadIn,
+                    StackLeniency = referenceBeatmapInfo.StackLeniency,
+                    SpecialStyle = referenceBeatmapInfo.SpecialStyle,
+                    LetterboxInBreaks = referenceBeatmapInfo.LetterboxInBreaks,
+                    WidescreenStoryboard = referenceBeatmapInfo.WidescreenStoryboard,
+                    EpilepsyWarning = referenceBeatmapInfo.EpilepsyWarning,
+                    SamplesMatchPlaybackRate = referenceBeatmapInfo.SamplesMatchPlaybackRate,
+                    DistanceSpacing = referenceBeatmapInfo.DistanceSpacing,
+                    BeatDivisor = referenceBeatmapInfo.BeatDivisor,
+                    GridSize = referenceBeatmapInfo.GridSize,
+                    TimelineZoom = referenceBeatmapInfo.TimelineZoom,
+                    Countdown = referenceBeatmapInfo.Countdown,
+                    CountdownOffset = referenceBeatmapInfo.CountdownOffset,
+                    Bookmarks = (int[])referenceBeatmapInfo.Bookmarks.Clone()
+                };
             }
 
             // populate circular beatmap set info <-> beatmap info references manually.