From 59bb6b8f7cbbde0078a51c88e51245bdc9ea88c3 Mon Sep 17 00:00:00 2001
From: Salman Ahmed <frenzibyte@gmail.com>
Date: Thu, 14 Apr 2022 13:43:09 +0300
Subject: [PATCH] Add background dim effect to inactive settings sections

---
 osu.Game/Overlays/Settings/SettingsSection.cs | 53 +++++++++++++------
 1 file changed, 36 insertions(+), 17 deletions(-)

diff --git a/osu.Game/Overlays/Settings/SettingsSection.cs b/osu.Game/Overlays/Settings/SettingsSection.cs
index 2539c32806..50a82b3d96 100644
--- a/osu.Game/Overlays/Settings/SettingsSection.cs
+++ b/osu.Game/Overlays/Settings/SettingsSection.cs
@@ -13,6 +13,7 @@ using osu.Framework.Localisation;
 using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 using osuTK;
+using osuTK.Graphics;
 
 namespace osu.Game.Overlays.Settings
 {
@@ -23,6 +24,8 @@ namespace osu.Game.Overlays.Settings
 
         private IBindable<SettingsSection> selectedSection;
 
+        private Box dim;
+
         private OsuSpriteText header;
 
         public abstract Drawable CreateIcon();
@@ -78,25 +81,40 @@ namespace osu.Game.Overlays.Settings
                 },
                 new Container
                 {
-                    Padding = new MarginPadding
-                    {
-                        Top = 28,
-                        Bottom = 40,
-                    },
+                    Padding = new MarginPadding { Top = border_size },
                     RelativeSizeAxes = Axes.X,
                     AutoSizeAxes = Axes.Y,
                     Children = new Drawable[]
                     {
-                        header = new OsuSpriteText
+                        dim = new Box
                         {
-                            Font = OsuFont.TorusAlternate.With(size: header_size),
-                            Text = Header,
-                            Margin = new MarginPadding
-                            {
-                                Horizontal = SettingsPanel.CONTENT_MARGINS
-                            }
+                            RelativeSizeAxes = Axes.Both,
+                            Colour = Color4.Black,
+                            Alpha = 0f,
                         },
-                        FlowContent
+                        new Container
+                        {
+                            RelativeSizeAxes = Axes.X,
+                            AutoSizeAxes = Axes.Y,
+                            Padding = new MarginPadding
+                            {
+                                Top = 24,
+                                Bottom = 40,
+                            },
+                            Children = new Drawable[]
+                            {
+                                header = new OsuSpriteText
+                                {
+                                    Font = OsuFont.TorusAlternate.With(size: header_size),
+                                    Text = Header,
+                                    Margin = new MarginPadding
+                                    {
+                                        Horizontal = SettingsPanel.CONTENT_MARGINS
+                                    }
+                                },
+                                FlowContent
+                            }
+                        }
                     }
                 },
             });
@@ -135,15 +153,16 @@ namespace osu.Game.Overlays.Settings
         private void updateContentFade()
         {
             float contentFade = 1;
-            float headerFade = 1;
+            float dimFade = 0;
 
             if (!isCurrentSection)
             {
-                contentFade = 0.25f;
-                headerFade = IsHovered ? 0.5f : 0.25f;
+                contentFade = IsHovered ? 0.5f : 0.25f;
+                dimFade = IsHovered ? 0.125f : 0.25f;
             }
 
-            header.FadeTo(headerFade, 500, Easing.OutQuint);
+            dim.FadeTo(dimFade, 500, Easing.OutQuint);
+            header.FadeTo(contentFade, 500, Easing.OutQuint);
             FlowContent.FadeTo(contentFade, 500, Easing.OutQuint);
         }
     }