RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reduce allocation in Playfield

This commit is contained in:
Andrei Zavatski 2024-02-02 04:53:48 +03:00
parent 7cdedfb6ca
commit 53c5483eba
1 changed files with 12 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
osu.Game/Rulesets/UI/Playfield.cs
View File

@ -247,10 +247,14 @@ protected void AddNested(Playfield otherPlayfield)
nestedPlayfields.Add(otherPlayfield); nestedPlayfields.Add(otherPlayfield);
} }
private Mod[] mods;
protected override void LoadComplete() protected override void LoadComplete()
{ {
base.LoadComplete(); base.LoadComplete();
mods = Mods?.ToArray();
// in the case a consumer forgets to add the HitObjectContainer, we will add it here. // in the case a consumer forgets to add the HitObjectContainer, we will add it here.
if (HitObjectContainer.Parent == null) if (HitObjectContainer.Parent == null)
AddInternal(HitObjectContainer); AddInternal(HitObjectContainer);
@ -260,9 +264,9 @@ protected override void Update()
{ {
base.Update(); base.Update();
if (!IsNested && Mods != null) if (!IsNested && mods != null)
{ {
foreach (var mod in Mods) foreach (Mod mod in mods)
{ {
if (mod is IUpdatableByPlayfield updatable) if (mod is IUpdatableByPlayfield updatable)
updatable.Update(this); updatable.Update(this);
@ -403,10 +407,13 @@ DrawableHitObject IPooledHitObjectProvider.GetPooledDrawableRepresentation(HitOb
// If this is the first time this DHO is being used, then apply the DHO mods. // If this is the first time this DHO is being used, then apply the DHO mods.
// This is done before Apply() so that the state is updated once when the hitobject is applied. // This is done before Apply() so that the state is updated once when the hitobject is applied.
if (Mods != null) if (mods != null)
{ {
foreach (var m in Mods.OfType<IApplicableToDrawableHitObject>()) foreach (Mod mod in mods)
m.ApplyToDrawableHitObject(dho); {
if (mod is IApplicableToDrawableHitObject applicable)
applicable.ApplyToDrawableHitObject(dho);
}
} }
} }