RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Apply review suggestions

This commit is contained in:
Endrik Tombak 2020-10-06 22:57:55 +03:00
parent a31fe5f5ff
commit 4c9840ccf1
1 changed files with 7 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game.Tests/Rulesets/Scoring/ScoreProcessorTest.cs
View File

@ -76,7 +76,7 @@ public void TestSingleOsuHit(ScoringMode scoringMode, HitResult hitResult, int e
[TestCase(ScoringMode.Classic, HitResult.LargeBonus, HitResult.LargeBonus, 150)]
public void TestFourVariousResultsOneMiss(ScoringMode scoringMode, HitResult hitResult, HitResult maxResult, double expectedScore)
{
var minResult = new JudgementResult(new HitObject(), new TestJudgement(hitResult)).Judgement.MinResult;
var minResult = new TestJudgement(hitResult).MinResult;
IBeatmap fourObjectBeatmap = new TestBeatmap(new RulesetInfo())
{
@ -109,8 +109,7 @@ public void TestFourVariousResultsOneMiss(ScoringMode scoringMode, HitResult hit
[TestCase(HitResult.LargeBonus, HitResult.IgnoreMiss)]
public void TestMinResults(HitResult hitResult, HitResult expectedMinResult)
{
var result = new JudgementResult(new HitObject(), new TestJudgement(hitResult));
Assert.IsTrue(result.Judgement.MinResult == expectedMinResult);
Assert.AreEqual(expectedMinResult, new TestJudgement(hitResult).MinResult);
}
[TestCase(HitResult.None, false)]
@ -130,7 +129,7 @@ public void TestMinResults(HitResult hitResult, HitResult expectedMinResult)
[TestCase(HitResult.LargeBonus, false)]
public void TestAffectsCombo(HitResult hitResult, bool expectedReturnValue)
{
Assert.IsTrue(hitResult.AffectsCombo() == expectedReturnValue);
Assert.AreEqual(expectedReturnValue, hitResult.AffectsCombo());
}
[TestCase(HitResult.None, false)]
@ -150,7 +149,7 @@ public void TestAffectsCombo(HitResult hitResult, bool expectedReturnValue)
[TestCase(HitResult.LargeBonus, false)]
public void TestAffectsAccuracy(HitResult hitResult, bool expectedReturnValue)
{
Assert.IsTrue(hitResult.AffectsAccuracy() == expectedReturnValue);
Assert.AreEqual(expectedReturnValue, hitResult.AffectsAccuracy());
}
[TestCase(HitResult.None, false)]
@ -170,7 +169,7 @@ public void TestAffectsAccuracy(HitResult hitResult, bool expectedReturnValue)
[TestCase(HitResult.LargeBonus, true)]
public void TestIsBonus(HitResult hitResult, bool expectedReturnValue)
{
Assert.IsTrue(hitResult.IsBonus() == expectedReturnValue);
Assert.AreEqual(expectedReturnValue, hitResult.IsBonus());
}
[TestCase(HitResult.None, false)]
@ -190,7 +189,7 @@ public void TestIsBonus(HitResult hitResult, bool expectedReturnValue)
[TestCase(HitResult.LargeBonus, true)]
public void TestIsHit(HitResult hitResult, bool expectedReturnValue)
{
Assert.IsTrue(hitResult.IsHit() == expectedReturnValue);
Assert.AreEqual(expectedReturnValue, hitResult.IsHit());
}
[TestCase(HitResult.None, false)]
@ -210,7 +209,7 @@ public void TestIsHit(HitResult hitResult, bool expectedReturnValue)
[TestCase(HitResult.LargeBonus, true)]
public void TestIsScorable(HitResult hitResult, bool expectedReturnValue)
{
Assert.IsTrue(hitResult.IsScorable() == expectedReturnValue);
Assert.AreEqual(expectedReturnValue, hitResult.IsScorable());
}
private class TestJudgement : Judgement