RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-09 16:39:15 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add back orphaning as a fail-safe

Browse Source
This commit is contained in:
smoogipoo 2020-02-21 19:41:00 +09:00
parent 05ff4de944
commit 4c083e0e7e
1 changed files with 15 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
osu.Game/Overlays/Comments/CommentsPage.cs
View File

@ -89,13 +89,15 @@ namespace osu.Game.Overlays.Comments
private readonly Dictionary<long, DrawableComment> commentDictionary = new Dictionary<long, DrawableComment>();
/// <summary>
/// Appends retrieved comments to the subtree of comments in this page.
/// Appends retrieved comments to the subtree rooted of comments in this page.
/// </summary>
/// <param name="bundle">The bundle of comments to add.</param>
private void appendComments([NotNull] CommentBundle bundle)
{
foreach (var child in bundle.Comments)
addNewComment(child);
var orphaned = new List<Comment>();
foreach (var topLevel in bundle.Comments)
addNewComment(topLevel);
foreach (var child in bundle.IncludedComments)
{
@ -106,6 +108,10 @@ namespace osu.Game.Overlays.Comments
addNewComment(child);
}
// Comments whose parents were seen later than themselves can now be added.
foreach (var o in orphaned)
addNewComment(o);
void addNewComment(Comment comment)
{
var drawableComment = getDrawableComment(comment);
@ -121,6 +127,12 @@ namespace osu.Game.Overlays.Comments
comment.ParentComment = parentDrawable.Comment;
parentDrawable.Replies.Add(drawableComment);
}
else
{
// The comment's parent has not been seen yet, so keep it orphaned for the time being. This can occur if the comments arrive out of order.
// Since this comment has now been seen, any further children can be added to it without being orphaned themselves.
orphaned.Add(comment);
}
}
}