mirror of https://github.com/ppy/osu
Merge pull request #27994 from bdach/timing-distribution-graph-only-basic
Do not show non-basic results in timing distribution graph
This commit is contained in:
commit
459f97891d
|
@ -82,6 +82,14 @@ public void TestVariousTypesOfHitResult()
|
|||
}).ToList());
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void TestNonBasicHitResultsAreIgnored()
|
||||
{
|
||||
createTest(CreateDistributedHitEvents(0, 50)
|
||||
.Select(h => new HitEvent(h.TimeOffset, 1.0, h.TimeOffset > 0 ? HitResult.Ok : HitResult.LargeTickHit, placeholder_object, placeholder_object, null))
|
||||
.ToList());
|
||||
}
|
||||
|
||||
[Test]
|
||||
public void TestMultipleWindowsOfHitResult()
|
||||
{
|
||||
|
|
|
@ -59,7 +59,7 @@ public partial class HitEventTimingDistributionGraph : CompositeDrawable
|
|||
/// <param name="hitEvents">The <see cref="HitEvent"/>s to display the timing distribution of.</param>
|
||||
public HitEventTimingDistributionGraph(IReadOnlyList<HitEvent> hitEvents)
|
||||
{
|
||||
this.hitEvents = hitEvents.Where(e => !(e.HitObject.HitWindows is HitWindows.EmptyHitWindows) && e.Result.IsHit()).ToList();
|
||||
this.hitEvents = hitEvents.Where(e => !(e.HitObject.HitWindows is HitWindows.EmptyHitWindows) && e.Result.IsBasic() && e.Result.IsHit()).ToList();
|
||||
bins = Enumerable.Range(0, total_timing_distribution_bins).Select(_ => new Dictionary<HitResult, int>()).ToArray<IDictionary<HitResult, int>>();
|
||||
}
|
||||
|
||||
|
|
Loading…
Reference in New Issue