Move HasFont to legacy skin extensions class instead

osu.Game.Rulesets.Catch/Skinning/CatchLegacySkinTransformer.cs

@@ -58,7 +58,7 @@ public override Drawable GetDrawableComponent(ISkinComponent component)
                     var fontOverlap = GetConfig<LegacySetting, float>(LegacySetting.ComboOverlap)?.Value ?? -2f;
 
                     // For simplicity, let's use legacy combo font texture existence as a way to identify legacy skins from default.
-                    if (HasFont(comboFont))
+                    if (this.HasFont(comboFont))
                         return new LegacyComboCounter(Source, comboFont, fontOverlap);
 
                     break;

osu.Game.Rulesets.Osu/Skinning/OsuLegacySkinTransformer.cs

@@ -94,7 +94,7 @@ public override Drawable GetDrawableComponent(ISkinComponent component)
                     var font = GetConfig<OsuSkinConfiguration, string>(OsuSkinConfiguration.HitCirclePrefix)?.Value ?? "default";
                     var overlap = GetConfig<OsuSkinConfiguration, float>(OsuSkinConfiguration.HitCircleOverlap)?.Value ?? -2;
 
-                    return !HasFont(font)
+                    return !this.HasFont(font)
                         ? null
                         : new LegacySpriteText(Source, font)
                         {

osu.Game/Skinning/LegacySkinExtensions.cs

@@ -62,6 +62,9 @@ IEnumerable<Texture> getTextures()
             }
         }
 
+        public static bool HasFont(this ISkin source, string fontPrefix)
+            => source.GetTexture($"{fontPrefix}-0") != null;
+
         public class SkinnableTextureAnimation : TextureAnimation
         {
             [Resolved(canBeNull: true)]

osu.Game/Skinning/LegacySkinTransformer.cs

@@ -47,7 +47,5 @@ public virtual SampleChannel GetSample(ISampleInfo sampleInfo)
         }
 
         public abstract IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup);
-
-        protected bool HasFont(string fontPrefix) => GetTexture($"{fontPrefix}-0") != null;
     }
 }