This commit is contained in:
Lucas A 2020-07-22 21:45:27 +02:00
parent 396ada7f39
commit 4102dae999
4 changed files with 11 additions and 28 deletions

View File

@ -11,26 +11,26 @@ namespace osu.Desktop.Windows
{
public class GameplayWinKeyHandler : Component
{
private Bindable<bool> allowScreenSuspension;
private Bindable<bool> disableWinKey;
private Bindable<bool> disableWinKeySetting;
private GameHost host;
[BackgroundDependencyLoader]
private void load(GameHost host, OsuConfigManager config, SessionStatics statics)
private void load(GameHost host, OsuConfigManager config)
{
this.host = host;
disableWinKey = statics.GetBindable<bool>(Static.DisableWindowsKey);
disableWinKey.ValueChanged += toggleWinKey;
allowScreenSuspension = host.AllowScreenSuspension.GetBoundCopy();
allowScreenSuspension.ValueChanged += toggleWinKey;
disableWinKeySetting = config.GetBindable<bool>(OsuSetting.GameplayDisableWinKey);
disableWinKeySetting.BindValueChanged(t => disableWinKey.TriggerChange(), true);
disableWinKey = config.GetBindable<bool>(OsuSetting.GameplayDisableWinKey);
disableWinKey.BindValueChanged(t => allowScreenSuspension.TriggerChange(), true);
}
private void toggleWinKey(ValueChangedEvent<bool> e)
{
if (e.NewValue && disableWinKeySetting.Value)
if (!e.NewValue && disableWinKey.Value)
host.InputThread.Scheduler.Add(WindowsKey.Disable);
else
host.InputThread.Scheduler.Add(WindowsKey.Enable);

View File

@ -12,14 +12,12 @@ namespace osu.Game.Configuration
{
Set(Static.LoginOverlayDisplayed, false);
Set(Static.MutedAudioNotificationShownOnce, false);
Set(Static.DisableWindowsKey, false);
}
}
public enum Static
{
LoginOverlayDisplayed,
MutedAudioNotificationShownOnce,
DisableWindowsKey
MutedAudioNotificationShownOnce
}
}

View File

@ -181,7 +181,7 @@ namespace osu.Game.Screens.Play
InternalChild = GameplayClockContainer = new GameplayClockContainer(Beatmap.Value, Mods.Value, DrawableRuleset.GameplayStartTime);
AddInternal(gameplayBeatmap = new GameplayBeatmap(playableBeatmap));
AddInternal(screenSuspension = new ScreenSuspensionHandler(GameplayClockContainer, DrawableRuleset.HasReplayLoaded));
AddInternal(screenSuspension = new ScreenSuspensionHandler(GameplayClockContainer));
dependencies.CacheAs(gameplayBeatmap);

View File

@ -8,7 +8,6 @@ using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Graphics;
using osu.Framework.Platform;
using osu.Game.Configuration;
namespace osu.Game.Screens.Play
{
@ -19,18 +18,13 @@ namespace osu.Game.Screens.Play
{
private readonly GameplayClockContainer gameplayClockContainer;
private Bindable<bool> isPaused;
private readonly Bindable<bool> hasReplayLoaded;
[Resolved]
private GameHost host { get; set; }
[Resolved]
private SessionStatics statics { get; set; }
public ScreenSuspensionHandler([NotNull] GameplayClockContainer gameplayClockContainer, Bindable<bool> hasReplayLoaded)
public ScreenSuspensionHandler([NotNull] GameplayClockContainer gameplayClockContainer)
{
this.gameplayClockContainer = gameplayClockContainer ?? throw new ArgumentNullException(nameof(gameplayClockContainer));
this.hasReplayLoaded = hasReplayLoaded.GetBoundCopy();
}
protected override void LoadComplete()
@ -42,12 +36,7 @@ namespace osu.Game.Screens.Play
Debug.Assert(host.AllowScreenSuspension.Value);
isPaused = gameplayClockContainer.IsPaused.GetBoundCopy();
isPaused.BindValueChanged(paused =>
{
host.AllowScreenSuspension.Value = paused.NewValue;
statics.Set(Static.DisableWindowsKey, !paused.NewValue && !hasReplayLoaded.Value);
}, true);
hasReplayLoaded.BindValueChanged(_ => isPaused.TriggerChange(), true);
isPaused.BindValueChanged(paused => host.AllowScreenSuspension.Value = paused.NewValue, true);
}
protected override void Dispose(bool isDisposing)
@ -55,13 +44,9 @@ namespace osu.Game.Screens.Play
base.Dispose(isDisposing);
isPaused?.UnbindAll();
hasReplayLoaded.UnbindAll();
if (host != null)
{
host.AllowScreenSuspension.Value = true;
statics.Set(Static.DisableWindowsKey, false);
}
}
}
}