RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Open mod select in a more reliable way

This commit is contained in:
Bartłomiej Dach 2020-02-09 14:39:27 +01:00
parent 590429b43b
commit 404cb61342
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game.Tests/Visual/UserInterface/TestSceneModSettings.cs
View File

@ -38,8 +38,8 @@ public void SetUp() => Schedule(() =>
public void TestButtonShowsOnCustomisableMod() public void TestButtonShowsOnCustomisableMod()
{ {
createModSelect(); createModSelect();
openModSelect();
AddStep("open", () => modSelect.Show());
AddAssert("button disabled", () => !modSelect.CustomiseButton.Enabled.Value); AddAssert("button disabled", () => !modSelect.CustomiseButton.Enabled.Value);
AddUntilStep("wait for button load", () => modSelect.ButtonsLoaded); AddUntilStep("wait for button load", () => modSelect.ButtonsLoaded);
AddStep("select mod", () => modSelect.SelectMod(testCustomisableMod)); AddStep("select mod", () => modSelect.SelectMod(testCustomisableMod));
@ -58,7 +58,7 @@ public void TestButtonShowsOnModAlreadyAdded()
AddAssert("mods still active", () => SelectedMods.Value.Count == 1); AddAssert("mods still active", () => SelectedMods.Value.Count == 1);
AddStep("open", () => modSelect.Show()); openModSelect();
AddAssert("button enabled", () => modSelect.CustomiseButton.Enabled.Value); AddAssert("button enabled", () => modSelect.CustomiseButton.Enabled.Value);
} }
@ -66,8 +66,8 @@ public void TestButtonShowsOnModAlreadyAdded()
public void TestAutoOpenOnModSelect() public void TestAutoOpenOnModSelect()
{ {
createModSelect(); createModSelect();
openModSelect();
AddStep("open", () => modSelect.Show());
AddAssert("Customisation closed", () => modSelect.ModSettingsContainer.Alpha == 0); AddAssert("Customisation closed", () => modSelect.ModSettingsContainer.Alpha == 0);
AddStep("select mod", () => modSelect.SelectMod(testCustomisableAutoOpenMod)); AddStep("select mod", () => modSelect.SelectMod(testCustomisableAutoOpenMod));
AddAssert("Customisation opened", () => modSelect.ModSettingsContainer.Alpha == 1); AddAssert("Customisation opened", () => modSelect.ModSettingsContainer.Alpha == 1);
@ -88,6 +88,12 @@ private void createModSelect()
}); });
} }
private void openModSelect()
{
AddStep("open", () => modSelect.Show());
AddUntilStep("wait for ready", () => modSelect.State.Value == Visibility.Visible && modSelect.ButtonsLoaded);
}
private class TestModSelectOverlay : ModSelectOverlay private class TestModSelectOverlay : ModSelectOverlay
{ {
public new Container ModSettingsContainer => base.ModSettingsContainer; public new Container ModSettingsContainer => base.ModSettingsContainer;