RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-24 15:53:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Suppress warnings

Browse Source
This commit is contained in:
smoogipoo 2019-11-12 13:41:54 +09:00
parent ed11c72d0b
commit 3f8928ca25
3 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Rulesets/Configuration/IRulesetConfigManager.cs
View File

@ -1,11 +1,12 @@
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence. // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text. // See the LICENCE file in the repository root for full licence text.
using System;
using osu.Framework.Configuration.Tracking; using osu.Framework.Configuration.Tracking;
namespace osu.Game.Rulesets.Configuration namespace osu.Game.Rulesets.Configuration
{ {
public interface IRulesetConfigManager : ITrackableConfigManager public interface IRulesetConfigManager : ITrackableConfigManager, IDisposable
{ {
} }
} }

2
osu.Game/Rulesets/Objects/Drawables/DrawableHitObject.cs
View File

@ -149,8 +149,10 @@ namespace osu.Game.Rulesets.Objects.Drawables
return; return;
if (HitObject.SampleControlPoint == null) if (HitObject.SampleControlPoint == null)
{
throw new ArgumentNullException(nameof(HitObject.SampleControlPoint), $"{nameof(HitObject)}s must always have an attached {nameof(HitObject.SampleControlPoint)}." throw new ArgumentNullException(nameof(HitObject.SampleControlPoint), $"{nameof(HitObject)}s must always have an attached {nameof(HitObject.SampleControlPoint)}."
+ $" This is an indication that {nameof(HitObject.ApplyDefaults)} has not been invoked on {this}."); + $" This is an indication that {nameof(HitObject.ApplyDefaults)} has not been invoked on {this}.");
}
samples = samples.Select(s => HitObject.SampleControlPoint.ApplyTo(s)).ToArray(); samples = samples.Select(s => HitObject.SampleControlPoint.ApplyTo(s)).ToArray();
foreach (var s in samples) foreach (var s in samples)

2
osu.Game/Rulesets/RulesetConfigCache.cs
View File

@ -43,7 +43,7 @@ namespace osu.Game.Rulesets
// ensures any potential database operations are finalised before game destruction. // ensures any potential database operations are finalised before game destruction.
foreach (var c in configCache.Values) foreach (var c in configCache.Values)
(c as IDisposable)?.Dispose(); c?.Dispose();
} }
} }
} }