RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-21 13:23:13 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix acoording to review

Browse Source
This commit is contained in:
Ron B 2020-08-15 21:34:17 +03:00
parent a1079bac32
commit 390e872730
No known key found for this signature in database
GPG Key ID: 6F5B32DE5E5FA80C
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game.Rulesets.Osu/Objects/Drawables/DrawableSpinner.cs
View File

@ -85,7 +85,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
} }
private SkinnableSound spinningSample; private SkinnableSound spinningSample;
private const float SPINNING_SAMPLE_INITAL_FREQUENCY = 1.0f; private const float SPINNING_SAMPLE_INITIAL_FREQUENCY = 1.0f;
private const float SPINNING_SAMPLE_MODULATED_BASE_FREQUENCY = 0.5f; private const float SPINNING_SAMPLE_MODULATED_BASE_FREQUENCY = 0.5f;
protected override void LoadSamples() protected override void LoadSamples()
@ -106,7 +106,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
{ {
Volume = { Value = 0 }, Volume = { Value = 0 },
Looping = true, Looping = true,
Frequency = { Value = SPINNING_SAMPLE_INITAL_FREQUENCY } Frequency = { Value = SPINNING_SAMPLE_INITIAL_FREQUENCY }
}); });
} }
} }
@ -171,7 +171,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
} }
[BackgroundDependencyLoader] [BackgroundDependencyLoader]
private void load(OsuColour colours, ISkinSource skin) private void load(OsuColour colours)
{ {
positionBindable.BindValueChanged(pos => Position = pos.NewValue); positionBindable.BindValueChanged(pos => Position = pos.NewValue);
positionBindable.BindTo(HitObject.PositionBindable); positionBindable.BindTo(HitObject.PositionBindable);
@ -179,6 +179,7 @@ namespace osu.Game.Rulesets.Osu.Objects.Drawables
protected override void ApplySkin(ISkinSource skin, bool allowFallback) protected override void ApplySkin(ISkinSource skin, bool allowFallback)
{ {
base.ApplySkin(skin, allowFallback);
spinnerFrequencyModulate = skin.GetConfig<OsuSkinConfiguration, bool>(OsuSkinConfiguration.SpinnerFrequencyModulate)?.Value ?? true; spinnerFrequencyModulate = skin.GetConfig<OsuSkinConfiguration, bool>(OsuSkinConfiguration.SpinnerFrequencyModulate)?.Value ?? true;
} }