RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-17 19:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove scroll-dropdown-into-view logic

Browse Source
This commit is contained in:
Salman Ahmed 2024-07-04 07:25:54 +03:00
parent 8658389854
commit 33711ba616
1 changed files with 2 additions and 33 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

35
osu.Game/Configuration/SettingSourceAttribute.cs
View File

@ -13,10 +13,8 @@ using osu.Framework.Extensions.ObjectExtensions;
using osu.Framework.Extensions.TypeExtensions;
using osu.Framework.Graphics;
using osu.Framework.Localisation;
using osu.Game.Graphics.Containers;
using osu.Game.Graphics.UserInterface;
using osu.Game.Overlays.Settings;
using osuTK;
namespace osu.Game.Configuration
{
@ -276,37 +274,8 @@ namespace osu.Game.Configuration
private partial class ModDropdownControl : DropdownControl
{
protected override DropdownMenu CreateMenu() => new ModDropdownMenu();
private partial class ModDropdownMenu : OsuDropdownMenu
{
public ModDropdownMenu()
{
// Set menu's max height low enough to workaround nested scroll issues (see https://github.com/ppy/osu-framework/issues/4536).
MaxHeight = 100;
}
protected override void UpdateSize(Vector2 newSize)
{
base.UpdateSize(newSize);
// todo: probably move this to OsuDropdown so that settings overlay can benefit from this as well.
if (newSize.Y > 0)
{
var scroll = this.FindClosestParent<OsuScrollContainer>();
if (scroll != null)
{
const float padding = 15;
float target = scroll.GetChildPosInContent(this, new Vector2(0, newSize.Y + padding));
if (target > scroll.Current + scroll.DisplayableContent)
scroll.ScrollTo(target - scroll.DisplayableContent);
}
}
}
}
// Set menu's max height low enough to workaround nested scroll issues (see https://github.com/ppy/osu-framework/issues/4536).
protected override DropdownMenu CreateMenu() => base.CreateMenu().With(m => m.MaxHeight = 100);
}
}
}