RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Implement `FindProvider` and `AllSources` properly on all test `ISkinSource`s

This commit is contained in:
Salman Ahmed 2021-06-22 12:02:21 +03:00
parent c1284940e1
commit 31cbb36a64
5 changed files with 10 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game.Rulesets.Osu.Tests/TestSceneCursorTrail.cs
View File

@ -114,9 +114,9 @@ public Texture GetTexture(string componentName, WrapMode wrapModeS, WrapMode wra
public IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => null;
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => null;
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => lookupFunction(this) ? this : null;
public IEnumerable<ISkin> AllSources => Enumerable.Empty<ISkin>();
public IEnumerable<ISkin> AllSources => new[] { this };
public event Action SourceChanged
{

4
osu.Game.Rulesets.Osu.Tests/TestSceneSkinFallbacks.cs
View File

@ -167,9 +167,9 @@ public Drawable GetDrawableComponent(ISkinComponent component)
public IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => null;
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => null;
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => lookupFunction(this) ? this : null;
public IEnumerable<ISkin> AllSources => Enumerable.Empty<ISkin>();
public IEnumerable<ISkin> AllSources => new[] { this };
public event Action SourceChanged;

2
osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableDrawable.cs
View File

@ -331,7 +331,7 @@ private class SkinSourceContainer : Container, ISkinSource
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => throw new NotImplementedException();
public IEnumerable<ISkin> AllSources => Enumerable.Empty<ISkin>();
public IEnumerable<ISkin> AllSources => throw new NotImplementedException();
public event Action SourceChanged
{

4
osu.Game.Tests/Visual/Gameplay/TestSceneSkinnableSound.cs
View File

@ -147,8 +147,8 @@ private class TestSkinSourceContainer : Container, ISkinSource, ISamplePlaybackD
public Texture GetTexture(string componentName, WrapMode wrapModeS, WrapMode wrapModeT) => source?.GetTexture(componentName, wrapModeS, wrapModeT);
public ISample GetSample(ISampleInfo sampleInfo) => source?.GetSample(sampleInfo);
public IBindable<TValue> GetConfig<TLookup, TValue>(TLookup lookup) => source?.GetConfig<TLookup, TValue>(lookup);
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => source?.FindProvider(lookupFunction);
public IEnumerable<ISkin> AllSources => source.AllSources;
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => lookupFunction(this) ? this : source?.FindProvider(lookupFunction);
public IEnumerable<ISkin> AllSources => new[] { this }.Concat(source?.AllSources);
public void TriggerSourceChanged()
{

5
osu.Game/Tests/Beatmaps/LegacyBeatmapSkinColourTest.cs
View File

@ -159,8 +159,9 @@ public event Action SourceChanged
remove { }
}
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => null;
public IEnumerable<ISkin> AllSources => Enumerable.Empty<ISkin>();
public ISkin FindProvider(Func<ISkin, bool> lookupFunction) => lookupFunction(this) ? this : null;
public IEnumerable<ISkin> AllSources => new[] { this };
}
}
}