Add localisation support to overlay header title/description

osu.Game/Localisation/ChatStrings.cs

@@ -0,0 +1,24 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation
+{
+    public static class ChatStrings
+    {
+        private const string prefix = "osu.Game.Localisation.Chat";
+
+        /// <summary>
+        /// "chat"
+        /// </summary>
+        public static LocalisableString HeaderTitle => new TranslatableString(getKey("header_title"), "chat");
+
+        /// <summary>
+        /// "join the real-time discussion"
+        /// </summary>
+        public static LocalisableString HeaderDescription => new TranslatableString(getKey("header_description"), "join the real-time discussion");
+
+        private static string getKey(string key) => $"{prefix}:{key}";
+    }
+}

osu.Game/Localisation/NotificationsStrings.cs

@@ -0,0 +1,24 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation
+{
+    public static class NotificationsStrings
+    {
+        private const string prefix = "osu.Game.Localisation.Notifications";
+
+        /// <summary>
+        /// "notifications"
+        /// </summary>
+        public static LocalisableString HeaderTitle => new TranslatableString(getKey("header_title"), "notifications");
+
+        /// <summary>
+        /// "waiting for 'ya"
+        /// </summary>
+        public static LocalisableString HeaderDescription => new TranslatableString(getKey("header_description"), "waiting for 'ya");
+
+        private static string getKey(string key) => $"{prefix}:{key}";
+    }
+}

osu.Game/Localisation/NowPlayingStrings.cs

@@ -0,0 +1,24 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation
+{
+    public static class NowPlayingStrings
+    {
+        private const string prefix = "osu.Game.Localisation.NowPlaying";
+
+        /// <summary>
+        /// "now playing"
+        /// </summary>
+        public static LocalisableString HeaderTitle => new TranslatableString(getKey("header_title"), "now playing");
+
+        /// <summary>
+        /// "manage the currently playing track"
+        /// </summary>
+        public static LocalisableString HeaderDescription => new TranslatableString(getKey("header_description"), "manage the currently playing track");
+
+        private static string getKey(string key) => $"{prefix}:{key}";
+    }
+}

osu.Game/Localisation/SettingsStrings.cs

@@ -0,0 +1,24 @@
+// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
+// See the LICENCE file in the repository root for full licence text.
+
+using osu.Framework.Localisation;
+
+namespace osu.Game.Localisation
+{
+    public static class SettingsStrings
+    {
+        private const string prefix = "osu.Game.Localisation.Settings";
+
+        /// <summary>
+        /// "settings"
+        /// </summary>
+        public static LocalisableString HeaderTitle => new TranslatableString(getKey("header_title"), "settings");
+
+        /// <summary>
+        /// "change the way osu! behaves"
+        /// </summary>
+        public static LocalisableString HeaderDescription => new TranslatableString(getKey("header_description"), "change the way osu! behaves");
+
+        private static string getKey(string key) => $"{prefix}:{key}";
+    }
+}

osu.Game/Overlays/ChatOverlay.cs

@@ -24,6 +24,8 @@
 using osuTK.Input;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Graphics.Textures;
+using osu.Framework.Localisation;
+using osu.Game.Localisation;
 using osu.Game.Online;
 
 namespace osu.Game.Overlays
@@ -31,8 +33,8 @@ namespace osu.Game.Overlays
     public class ChatOverlay : OsuFocusedOverlayContainer, INamedOverlayComponent
     {
         public string IconTexture => "Icons/Hexacons/messaging";
-        public string Title => "chat";
-        public string Description => "join the real-time discussion";
+        public LocalisableString Title => ChatStrings.HeaderTitle;
+        public LocalisableString Description => ChatStrings.HeaderDescription;
 
         private const float textbox_height = 60;
         private const float channel_selection_min_height = 0.3f;

osu.Game/Overlays/FullscreenOverlay.cs

@@ -8,6 +8,7 @@
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.Effects;
 using osu.Framework.Graphics.Shapes;
+using osu.Framework.Localisation;
 using osu.Game.Graphics.Containers;
 using osu.Game.Online.API;
 using osuTK.Graphics;
@@ -18,8 +19,8 @@ public abstract class FullscreenOverlay<T> : WaveOverlayContainer, INamedOverlay
         where T : OverlayHeader
     {
         public virtual string IconTexture => Header.Title.IconTexture ?? string.Empty;
-        public virtual string Title => Header.Title.Title ?? string.Empty;
-        public virtual string Description => Header.Title.Description ?? string.Empty;
+        public virtual LocalisableString Title => Header.Title.Title;
+        public virtual LocalisableString Description => Header.Title.Description;
 
         public T Header { get; }
 

osu.Game/Overlays/INamedOverlayComponent.cs

@@ -1,14 +1,16 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using osu.Framework.Localisation;
+
 namespace osu.Game.Overlays
 {
     public interface INamedOverlayComponent
     {
         string IconTexture { get; }
 
-        string Title { get; }
+        LocalisableString Title { get; }
 
-        string Description { get; }
+        LocalisableString Description { get; }
     }
 }

osu.Game/Overlays/NotificationOverlay.cs

@@ -11,16 +11,18 @@
 using System;
 using osu.Framework.Allocation;
 using osu.Framework.Bindables;
+using osu.Framework.Localisation;
 using osu.Framework.Threading;
 using osu.Game.Graphics;
+using osu.Game.Localisation;
 
 namespace osu.Game.Overlays
 {
     public class NotificationOverlay : OsuFocusedOverlayContainer, INamedOverlayComponent
     {
         public string IconTexture => "Icons/Hexacons/notification";
-        public string Title => "notifications";
-        public string Description => "waiting for 'ya";
+        public LocalisableString Title => NotificationsStrings.HeaderTitle;
+        public LocalisableString Description => NotificationsStrings.HeaderDescription;
 
         private const float width = 320;
 

osu.Game/Overlays/NowPlayingOverlay.cs

@@ -19,6 +19,7 @@
 using osu.Game.Graphics.Containers;
 using osu.Game.Graphics.Sprites;
 using osu.Game.Graphics.UserInterface;
+using osu.Game.Localisation;
 using osu.Game.Overlays.Music;
 using osuTK;
 using osuTK.Graphics;
@@ -28,8 +29,8 @@ namespace osu.Game.Overlays
     public class NowPlayingOverlay : OsuFocusedOverlayContainer, INamedOverlayComponent
     {
         public string IconTexture => "Icons/Hexacons/music";
-        public string Title => "now playing";
-        public string Description => "manage the currently playing track";
+        public LocalisableString Title => NowPlayingStrings.HeaderTitle;
+        public LocalisableString Description => NowPlayingStrings.HeaderDescription;
 
         private const float player_height = 130;
         private const float transition_length = 800;

osu.Game/Overlays/OverlayTitle.cs

@@ -6,6 +6,7 @@
 using osu.Framework.Graphics.Containers;
 using osu.Framework.Graphics.Sprites;
 using osu.Framework.Graphics.Textures;
+using osu.Framework.Localisation;
 using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 using osuTK;
@@ -19,15 +20,15 @@ public abstract class OverlayTitle : CompositeDrawable, INamedOverlayComponent
         private readonly OsuSpriteText titleText;
         private readonly Container icon;
 
-        private string title;
+        private LocalisableString title;
 
-        public string Title
+        public LocalisableString Title
         {
             get => title;
             protected set => titleText.Text = title = value;
         }
 
-        public string Description { get; protected set; }
+        public LocalisableString Description { get; protected set; }
 
         private string iconTexture;
 

osu.Game/Overlays/Settings/SettingsHeader.cs

@@ -4,6 +4,7 @@
 using osu.Framework.Allocation;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
+using osu.Framework.Localisation;
 using osu.Game.Graphics;
 using osu.Game.Graphics.Sprites;
 
@@ -11,10 +12,10 @@ namespace osu.Game.Overlays.Settings
 {
     public class SettingsHeader : Container
     {
-        private readonly string heading;
-        private readonly string subheading;
+        private readonly LocalisableString heading;
+        private readonly LocalisableString subheading;
 
-        public SettingsHeader(string heading, string subheading)
+        public SettingsHeader(LocalisableString heading, LocalisableString subheading)
         {
             this.heading = heading;
             this.subheading = subheading;

osu.Game/Overlays/SettingsOverlay.cs

@@ -10,14 +10,16 @@
 using System.Collections.Generic;
 using System.Linq;
 using osu.Framework.Bindables;
+using osu.Framework.Localisation;
+using osu.Game.Localisation;
 
 namespace osu.Game.Overlays
 {
     public class SettingsOverlay : SettingsPanel, INamedOverlayComponent
     {
         public string IconTexture => "Icons/Hexacons/settings";
-        public string Title => "settings";
-        public string Description => "change the way osu! behaves";
+        public LocalisableString Title => SettingsStrings.HeaderTitle;
+        public LocalisableString Description => SettingsStrings.HeaderDescription;
 
         protected override IEnumerable<SettingsSection> CreateSections() => new SettingsSection[]
         {