RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-22 21:47:12 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add TODO about beatmap skin fallback support

Browse Source
This commit is contained in:
Dean Herbert 2021-06-08 12:12:14 +09:00
parent 88b87b98a8
commit 27e3de3ea3
1 changed files with 3 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Skinning/SkinManager.cs
View File

@ -235,6 +235,9 @@ namespace osu.Game.Skinning
if (selectedSkin != null)
return selectedSkin;
// TODO: we also want to return a DefaultLegacySkin here if the current *beatmap* is providing any skinned elements.
// When attempting to address this, we may want to move the full DefaultLegacySkin fallback logic to within Player itself (to better allow
// for beatmap skin visibility).
if (CurrentSkin.Value is LegacySkin)
return func(defaultLegacySkin);