RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-01-06 14:20:03 +00:00
Code Issues Packages Projects Releases Wiki Activity

Reword and xmldoc some comments

Browse Source
This commit is contained in:
Dean Herbert 2020-11-30 15:54:20 +09:00
parent 31cfaefdeb
commit 2745659986
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
osu.Game/Rulesets/UI/Scrolling/ScrollingHitObjectContainer.cs
View File

@ -17,11 +17,14 @@ namespace osu.Game.Rulesets.UI.Scrolling
private readonly IBindable<double> timeRange = new BindableDouble(); private readonly IBindable<double> timeRange = new BindableDouble();
private readonly IBindable<ScrollingDirection> direction = new Bindable<ScrollingDirection>(); private readonly IBindable<ScrollingDirection> direction = new Bindable<ScrollingDirection>();
// The lifetime of a hit object in this will be computed in next update. /// <summary>
/// Hit objects which require lifetime computation in the next update call.
/// </summary>
private readonly HashSet<DrawableHitObject> toComputeLifetime = new HashSet<DrawableHitObject>(); private readonly HashSet<DrawableHitObject> toComputeLifetime = new HashSet<DrawableHitObject>();
// The layout (length if IHasDuration, and nested object positions) of a hit object *not* in this set will be computed in next updated. /// <summary>
// Only objects in `AliveObjects` are considered, to prevent a massive recomputation when scrolling speed or something changes. /// A set containing all <see cref="HitObjectContainer.AliveObjects"/> which have an up-to-date layout.
/// </summary>
private readonly HashSet<DrawableHitObject> layoutComputed = new HashSet<DrawableHitObject>(); private readonly HashSet<DrawableHitObject> layoutComputed = new HashSet<DrawableHitObject>();
[Resolved] [Resolved]
@ -223,8 +226,7 @@ namespace osu.Game.Rulesets.UI.Scrolling
toComputeLifetime.Clear(); toComputeLifetime.Clear();
// An assumption is that this update won't affect lifetime, // only AliveObjects need to be considered for layout (reduces overhead in the case of scroll speed changes).
// but this is satisfied in practice because otherwise the hit object won't be aligned to its `StartTime`.
foreach (var obj in AliveObjects) foreach (var obj in AliveObjects)
{ {
if (layoutComputed.Contains(obj)) if (layoutComputed.Contains(obj))