RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-11 17:42:28 +00:00
Code Issues Packages Projects Releases Wiki Activity

Refrain from attempting to clear skin sources in disposal

Browse Source 
`Drawable.Dispose` is usually in an asynchronous context (async disposals stuff) and therefore this could cause a "collection was modified; enumeration opeartion may not execute" exception.
This commit is contained in:
Salman Ahmed 2021-06-10 17:23:15 +03:00
parent 680791301f
commit 2240e2c39c
1 changed files with 2 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

3
osu.Game/Skinning/SkinProvidingContainer.cs
View File

@ -210,7 +210,8 @@ namespace osu.Game.Skinning
if (fallbackSource != null) if (fallbackSource != null)
fallbackSource.SourceChanged -= OnSourceChanged; fallbackSource.SourceChanged -= OnSourceChanged;
SkinSources.Clear(); foreach (var source in SkinSources.OfType<ISkinSource>())
source.SourceChanged -= OnSourceChanged;
} }
private class NoFallbackProxy : ISkinSource private class NoFallbackProxy : ISkinSource