RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-03-18 08:32:26 +00:00
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #12392 from peppy/avoid-score-online-id-conflicts

Browse Source 
Don't store online IDs from score submission responses for now
This commit is contained in:
Dan Balasescu 2021-04-13 15:40:03 +09:00 committed by GitHub
commit 20a432c083
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
osu.Game/Screens/Play/SubmittingPlayer.cs
View File

@ -109,7 +109,12 @@ namespace osu.Game.Screens.Play
request.Success += s =>
{
score.ScoreInfo.OnlineScoreID = s.ID;
// For the time being, online ID responses are not really useful for anything.
// In addition, the IDs provided via new (lazer) endpoints are based on a different autoincrement from legacy (stable) scores.
//
// Until we better define the server-side logic behind this, let's not store the online ID to avoid potential unique constraint
// conflicts across various systems (ie. solo and multiplayer).
// score.ScoreInfo.OnlineScoreID = s.ID;
tcs.SetResult(true);
};