RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2024-12-18 12:55:37 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove problematic online ID check

Browse Source
This commit is contained in:
Bartłomiej Dach 2024-10-30 07:40:08 +01:00
parent 40c2d4e942
commit 1a2e323c11
No known key found for this signature in database
1 changed files with 5 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

10
osu.Game/Beatmaps/BeatmapUpdaterMetadataLookup.cs
View File

@ -85,11 +85,11 @@ namespace osu.Game.Beatmaps
private bool shouldDiscardLookupResult(OnlineBeatmapMetadata result, BeatmapInfo beatmapInfo)
{
if (beatmapInfo.OnlineID > 0 && result.BeatmapID != beatmapInfo.OnlineID)
{
Logger.Log($"Discarding metadata lookup result due to mismatching online ID (expected: {beatmapInfo.OnlineID} actual: {result.BeatmapID})", LoggingTarget.Database);
return true;
}
// previously this used to check whether the `OnlineID` of the looked-up beatmap matches the local `OnlineID`.
// unfortunately it appears that historically stable mappers would apply crude hacks to fix unspecified "issues" with submission
// which would amount to reusing online IDs of other beatmaps.
// this means that the online ID in the `.osu` file is not reliable, and this cannot be fixed server-side
// because updating the maps retroactively would break stable (by losing all of users' local scores).
if (beatmapInfo.OnlineID == -1 && result.MD5Hash != beatmapInfo.MD5Hash)
{