RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Merge pull request #2660 from smoogipoo/fix-holdnote-judgement 

Fix mania hold notes displaying judgements
This commit is contained in:
Dean Herbert 2018-05-28 18:35:02 +09:00 committed by GitHub
parent ce8a6cfc53 31cbec99a1
commit 1572635fc8
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
osu.Game.Rulesets.Mania/Objects/Drawables/DrawableHoldNote.cs
View File

@ -18,6 +18,8 @@ namespace osu.Game.Rulesets.Mania.Objects.Drawables
/// </summary>
public class DrawableHoldNote : DrawableManiaHitObject<HoldNote>, IKeyBindingHandler<ManiaAction>
{
public override bool DisplayJudgement => false;
private readonly DrawableNote head;
private readonly DrawableNote tail;

2
osu.Game.Rulesets.Mania/UI/Column.cs
View File

@ -213,7 +213,7 @@ public override void Add(DrawableHitObject hitObject)
internal void OnJudgement(DrawableHitObject judgedObject, Judgement judgement)
{
if (!judgement.IsHit)
if (!judgement.IsHit || !judgedObject.DisplayJudgement)
return;
explosionContainer.Add(new HitExplosion(judgedObject));

3
osu.Game.Rulesets.Mania/UI/ManiaStage.cs
View File

@ -171,6 +171,9 @@ public override void Add(DrawableHitObject h)
internal void OnJudgement(DrawableHitObject judgedObject, Judgement judgement)
{
if (!judgedObject.DisplayJudgement)
return;
judgements.Clear();
judgements.Add(new DrawableManiaJudgement(judgement, judgedObject)
{