RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-27 16:11:43 +00:00
Code Issues Packages Projects Releases Wiki Activity

Remove unnecessary sample stop in Restart()

Browse Source 
It is unnecessary, as a successful restart will exit the current player
screen, and `OnExiting()` has another `StopSampleAndRemoveFilters()`
call, which means that in the restart flow the sample was actually
getting stopped twice.

Standard exit flow is fine, it only stopped the sample once.
This commit is contained in:
Bartłomiej Dach 2023-01-22 09:24:12 +01:00
parent db0b69db6b
commit 0edfd24410
No known key found for this signature in database
1 changed files with 0 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game/Screens/Play/Player.cs
View File

@ -678,7 +678,6 @@ namespace osu.Game.Screens.Play
sampleRestart?.Play(); sampleRestart?.Play();
RestartRequested?.Invoke(quickRestart); RestartRequested?.Invoke(quickRestart);
failAnimationLayer.StopSample();
PerformExit(false); PerformExit(false);
} }