RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-08 14:17:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix changelog overlay potentially adding children after disposal

Browse Source
This commit is contained in:
Dean Herbert 2019-09-13 17:21:47 +09:00
parent 7cb79dd760
commit 0cc21c9c74
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
osu.Game/Overlays/ChangelogOverlay.cs
View File

@ -170,7 +170,7 @@ namespace osu.Game.Overlays
var tcs = new TaskCompletionSource<bool>(); var tcs = new TaskCompletionSource<bool>();
var req = new GetChangelogRequest(); var req = new GetChangelogRequest();
req.Success += res => req.Success += res => Schedule(() =>
{ {
// remap streams to builds to ensure model equality // remap streams to builds to ensure model equality
res.Builds.ForEach(b => b.UpdateStream = res.Streams.Find(s => s.Id == b.UpdateStream.Id)); res.Builds.ForEach(b => b.UpdateStream = res.Streams.Find(s => s.Id == b.UpdateStream.Id));
@ -182,7 +182,7 @@ namespace osu.Game.Overlays
header.Streams.Populate(res.Streams); header.Streams.Populate(res.Streams);
tcs.SetResult(true); tcs.SetResult(true);
}; });
req.Failure += _ => initialFetchTask = null; req.Failure += _ => initialFetchTask = null;
req.Perform(API); req.Perform(API);