RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-03-05 19:11:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix slider bars reloading each time the tablet size is changed

Browse Source
This commit is contained in:
Dean Herbert 2021-03-16 15:57:29 +09:00
parent 926e40925e
commit 0a6525baee
1 changed files with 6 additions and 9 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
osu.Game/Overlays/Settings/Sections/Input/TabletSettings.cs
View File

@ -4,10 +4,8 @@
using System.Drawing;
using osu.Framework.Allocation;
using osu.Framework.Bindables;
using osu.Framework.Configuration;
using osu.Framework.Graphics;
using osu.Framework.Input.Handlers.Tablet;
using osu.Game.Configuration;
namespace osu.Game.Overlays.Settings.Sections.Input
{
@ -33,9 +31,8 @@ namespace osu.Game.Overlays.Settings.Sections.Input
}
[BackgroundDependencyLoader]
private void load(OsuConfigManager osuConfig, FrameworkConfigManager config)
private void load()
{
// TODO: this should all eventually be replaced with a control that handles BindableSize.
areaOffset.BindTo(tabletHandler.AreaOffset);
areaOffset.BindValueChanged(val =>
{
@ -59,6 +56,9 @@ namespace osu.Game.Overlays.Settings.Sections.Input
((IBindable<Size>)tabletSize).BindTo(tabletHandler.TabletSize);
tabletSize.BindValueChanged(val =>
{
if (tabletSize.Value == System.Drawing.Size.Empty)
return;
// todo: these should propagate from a TabletChanged event or similar.
offsetX.MaxValue = val.NewValue.Width;
sizeX.Default = sizeX.MaxValue = val.NewValue.Width;
@ -72,11 +72,8 @@ namespace osu.Game.Overlays.Settings.Sections.Input
private void updateDisplay()
{
if (tabletSize.Value == System.Drawing.Size.Empty)
{
Clear();
if (Children.Count > 0)
return;
}
Children = new Drawable[]
{
@ -103,7 +100,7 @@ namespace osu.Game.Overlays.Settings.Sections.Input
new TabletAreaSelection(tabletHandler)
{
RelativeSizeAxes = Axes.X,
Height = 100,
Height = 300,
}
};
}