RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix imports with no matching beatmap IDs still retaining a potentially invalid set ID

This commit is contained in:
Dean Herbert 2020-03-30 11:52:11 +09:00
parent 113bbe8c4d
commit 09d860d5f5
1 changed files with 6 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
osu.Game/Beatmaps/BeatmapManager.cs
View File

@ -87,7 +87,7 @@ protected override ArchiveDownloadRequest<BeatmapSetInfo> CreateDownloadRequest(
protected override bool ShouldDeleteArchive(string path) => Path.GetExtension(path)?.ToLowerInvariant() == ".osz";
protected override Task Populate(BeatmapSetInfo beatmapSet, ArchiveReader archive, CancellationToken cancellationToken = default)
protected override async Task Populate(BeatmapSetInfo beatmapSet, ArchiveReader archive, CancellationToken cancellationToken = default)
{
if (archive != null)
beatmapSet.Beatmaps = createBeatmapDifficulties(beatmapSet.Files);
@ -103,7 +103,11 @@ protected override Task Populate(BeatmapSetInfo beatmapSet, ArchiveReader archiv
validateOnlineIds(beatmapSet);
return updateQueue.UpdateAsync(beatmapSet, cancellationToken);
await updateQueue.UpdateAsync(beatmapSet, cancellationToken);
// ensure at least one beatmap was able to retrieve an online ID, else drop the set ID.
if (!beatmapSet.Beatmaps.Any(b => b.OnlineBeatmapID > 0))
beatmapSet.OnlineBeatmapSetID = null;
}
protected override void PreImport(BeatmapSetInfo beatmapSet)