RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove AffectsAccuracy for now

This commit is contained in:
smoogipooo 2017-09-13 15:42:47 +09:00
parent ba3e44cd71
commit 05ac23f99a
5 changed files with 3 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
osu.Game.Rulesets.Mania/Judgements/HoldNoteTickJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Mania.Judgements
public class HoldNoteTickJudgement : ManiaJudgement public class HoldNoteTickJudgement : ManiaJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool AffectsAccuracy => false;
protected override int NumericResultFor(HitResult result) => 20; protected override int NumericResultFor(HitResult result) => 20;
} }

1
osu.Game.Rulesets.Taiko/Judgements/TaikoDrumRollTickJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Taiko.Judgements
public class TaikoDrumRollTickJudgement : TaikoJudgement public class TaikoDrumRollTickJudgement : TaikoJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool AffectsAccuracy => false;
protected override int NumericResultFor(HitResult result) protected override int NumericResultFor(HitResult result)
{ {

1
osu.Game.Rulesets.Taiko/Judgements/TaikoStrongHitJudgement.cs
View File

@ -8,7 +8,6 @@ namespace osu.Game.Rulesets.Taiko.Judgements
public class TaikoStrongHitJudgement : TaikoJudgement public class TaikoStrongHitJudgement : TaikoJudgement
{ {
public override bool AffectsCombo => false; public override bool AffectsCombo => false;
public override bool AffectsAccuracy => false;
public TaikoStrongHitJudgement() public TaikoStrongHitJudgement()
{ {

5
osu.Game/Rulesets/Judgements/Judgement.cs
View File

@ -25,11 +25,6 @@ public class Judgement
/// </summary> /// </summary>
public double TimeOffset { get; internal set; } public double TimeOffset { get; internal set; }
/// <summary>
/// Whether the <see cref="Result"/> should be considered as a factor in the accuracy percentage and portion.
/// </summary>
public virtual bool AffectsAccuracy => true;
/// <summary> /// <summary>
/// Whether the <see cref="Result"/> should affect the combo portion of the score. /// Whether the <see cref="Result"/> should affect the combo portion of the score.
/// If false, the <see cref="Result"/> will be considered for the bonus portion of the score. /// If false, the <see cref="Result"/> will be considered for the bonus portion of the score.

7
osu.Game/Rulesets/Scoring/ScoreProcessor.cs
View File

@ -152,7 +152,7 @@ public abstract class ScoreProcessor<TObject> : ScoreProcessor
{ {
private const double max_score = 1000000; private const double max_score = 1000000;
public readonly Bindable<ScoringMode> Mode = new Bindable<ScoringMode>(ScoringMode.Exponential); public readonly Bindable<ScoringMode> Mode = new Bindable<ScoringMode>(ScoringMode.Standardised);
protected sealed override bool HasCompleted => Hits == MaxHits; protected sealed override bool HasCompleted => Hits == MaxHits;
@ -219,13 +219,12 @@ protected virtual void OnNewJudgement(Judgement judgement)
baseScore += judgement.NumericResult; baseScore += judgement.NumericResult;
rollingMaxBaseScore += judgement.MaxNumericResult; rollingMaxBaseScore += judgement.MaxNumericResult;
Hits++;
} }
else if (judgement.IsHit) else if (judgement.IsHit)
bonusScore += judgement.NumericResult; bonusScore += judgement.NumericResult;
if (judgement.AffectsAccuracy)
Hits++;
if (rollingMaxBaseScore != 0) if (rollingMaxBaseScore != 0)
Accuracy.Value = baseScore / rollingMaxBaseScore; Accuracy.Value = baseScore / rollingMaxBaseScore;