RepoMirrors/osu
1
0
Fork 0
mirror of https://github.com/ppy/osu synced 2025-02-17 19:07:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

Add more comprehensive commenting and simplify base call logic

Browse Source 
We can call the base method regardless for better safety. Worst case
it's just going to run `Stop()` twice anyway.
This commit is contained in:
Dean Herbert 2021-02-01 16:43:53 +09:00
parent ee89aa159c
commit 05982f42ab
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
osu.Game/Storyboards/Drawables/DrawableStoryboardSample.cs
View File

@ -46,14 +46,15 @@ namespace osu.Game.Storyboards.Drawables
{ {
if (!RequestedPlaying) return; if (!RequestedPlaying) return;
// non-looping storyboard samples should be stopped immediately when sample playback is disabled if (!Looping && disabled.NewValue)
if (!Looping)
{ {
if (disabled.NewValue) // the default behaviour for sample disabling is to allow one-shot samples to play out.
Stop(); // storyboards regularly have long running samples that can cause this behaviour to lead to unintended results.
// for this reason, we immediately stop such samples.
Stop();
} }
else
base.SamplePlaybackDisabledChanged(disabled); base.SamplePlaybackDisabledChanged(disabled);
} }
protected override void Update() protected override void Update()