From 02168c6c2fb7f31907c5d02797fbc1508075dd87 Mon Sep 17 00:00:00 2001
From: Andrei Zavatski <megaman9919@gmail.com>
Date: Sat, 14 Nov 2020 19:17:01 +0300
Subject: [PATCH] Implement dates with zero count fill

---
 .../Historical/ChartProfileSubsection.cs      | 28 ++++++++++++++++++-
 .../Sections/Historical/ProfileLineChart.cs   |  2 +-
 2 files changed, 28 insertions(+), 2 deletions(-)

diff --git a/osu.Game/Overlays/Profile/Sections/Historical/ChartProfileSubsection.cs b/osu.Game/Overlays/Profile/Sections/Historical/ChartProfileSubsection.cs
index 24083c9a79..38224dd177 100644
--- a/osu.Game/Overlays/Profile/Sections/Historical/ChartProfileSubsection.cs
+++ b/osu.Game/Overlays/Profile/Sections/Historical/ChartProfileSubsection.cs
@@ -1,6 +1,7 @@
 // Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 // See the LICENCE file in the repository root for full licence text.
 
+using System.Collections.Generic;
 using osu.Framework.Bindables;
 using osu.Framework.Graphics;
 using osu.Framework.Graphics.Containers;
@@ -38,7 +39,32 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
 
             if (values?.Length > 1)
             {
-                chart.Values = values;
+                // Fill dates with 0 count
+
+                var newValues = new List<UserHistoryCount> { values[0] };
+                var newLast = values[0];
+
+                for (int i = 1; i < values.Length; i++)
+                {
+                    while (hasMissingDates(newLast, values[i]))
+                    {
+                        newValues.Add(newLast = new UserHistoryCount
+                        {
+                            Count = 0,
+                            Date = newLast.Date.AddMonths(1)
+                        });
+                    }
+
+                    newValues.Add(newLast = values[i]);
+                }
+
+                static bool hasMissingDates(UserHistoryCount prev, UserHistoryCount current)
+                {
+                    var possibleCurrent = prev.Date.AddMonths(1);
+                    return possibleCurrent != current.Date;
+                }
+
+                chart.Values = newValues.ToArray();
                 Show();
                 return;
             }
diff --git a/osu.Game/Overlays/Profile/Sections/Historical/ProfileLineChart.cs b/osu.Game/Overlays/Profile/Sections/Historical/ProfileLineChart.cs
index 55fa6c5400..7cd529a726 100644
--- a/osu.Game/Overlays/Profile/Sections/Historical/ProfileLineChart.cs
+++ b/osu.Game/Overlays/Profile/Sections/Historical/ProfileLineChart.cs
@@ -19,7 +19,7 @@ namespace osu.Game.Overlays.Profile.Sections.Historical
     {
         private UserHistoryCount[] values;
 
-        [CanBeNull]
+        [NotNull]
         public UserHistoryCount[] Values
         {
             get => values;