osu/osu.Game/Online/API/APIException.cs

// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using System;

namespace osu.Game.Online.API
{
    public class APIException : InvalidOperationException
    {
        public APIException(string message, Exception? innerException)
            : base(message, innerException)
        {
        }
    }
}
-												Automated pass

											
										
										
											2023-06-22 16:37:25 +00:00
+								// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
-												Fix API request potentially firing failed events after completion

Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.

This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.

Closes https://github.com/ppy/osu/issues/13632.

											
										
										
											2021-07-19 11:27:00 +00:00
+								// See the LICENCE file in the repository root for full licence text.
 								using System;
 								namespace osu.Game.Online.API
 								{
 								    public class APIException : InvalidOperationException
 								    {
-												Fix remaining obvious CI inspections

											
										
										
											2023-06-24 14:07:01 +00:00
+								        public APIException(string message, Exception? innerException)
-												Fix clear identifier typos

											
										
										
											2021-12-10 05:04:31 +00:00
+								            : base(message, innerException)
-												Fix API request potentially firing failed events after completion

Specifically, `Cancel()` calls were not thread safe. Due to a series of
events, `ListPollingComponent` could call `Cancel` from a non-update
thread, leading to a race condition where both a `Success` and `Fail`
event can be fired.

This is intended to be the simplest fix possible, locking and guarding
specifically on the callbacks. Further work could be done in the future
to improve the flow surrounding `pendingFailure`, potentially reducing
redundant work and cleaning up the code, but that's not happening here.

Closes https://github.com/ppy/osu/issues/13632.

											
										
										
											2021-07-19 11:27:00 +00:00
+								        {
 								        }
 								    }
 								}