RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
osu/osu.Game/Rulesets/Judgements/IgnoreJudgement.cs

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

15 lines
371 B
C#
Raw Normal View History

Fix hitobjects with unknown lifetimes by enforcing non-null judgement We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 04:01:30 +00:00
// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
Update licence header (and remove year)
2019-01-24 08:43:03 +00:00
// See the LICENCE file in the repository root for full licence text.
Fixed taiko swell hp and scoring
2018-11-29 15:05:13 +00:00
Automated #nullable processing
2022-06-17 07:37:17 +00:00
#nullable disable
Fixed taiko swell hp and scoring
2018-11-29 15:05:13 +00:00
using osu.Game.Rulesets.Scoring;
Fix hitobjects with unknown lifetimes by enforcing non-null judgement We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 04:01:30 +00:00
namespace osu.Game.Rulesets.Judgements
Fixed taiko swell hp and scoring
2018-11-29 15:05:13 +00:00
{
Fix hitobjects with unknown lifetimes by enforcing non-null judgement We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward CreateJudgement() must be implemented and return a non-null judgement. This fixes BananaShower and JuiceStreams in osu!catch. This also makes HitObject abstract and cleans up convert HitObject implementations.
2020-02-23 04:01:30 +00:00
public class IgnoreJudgement : Judgement
Fixed taiko swell hp and scoring
2018-11-29 15:05:13 +00:00
{
Fix a few missed judgements
2020-09-29 06:20:47 +00:00
public override HitResult MaxResult => HitResult.IgnoreHit;
Fixed taiko swell hp and scoring
2018-11-29 15:05:13 +00:00
}
}