osu/osu.Game.Rulesets.Taiko/Objects/SwellTick.cs

// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
// See the LICENCE file in the repository root for full licence text.

using osu.Game.Rulesets.Judgements;
using osu.Game.Rulesets.Scoring;

namespace osu.Game.Rulesets.Taiko.Objects
{
    public class SwellTick : TaikoHitObject
    {
        public override Judgement CreateJudgement() => new IgnoreJudgement();

        protected override HitWindows CreateHitWindows() => HitWindows.Empty;
    }
}
-												Update licence header (and remove year)

											
										
										
											2019-01-24 08:43:03 +00:00
+								// Copyright (c) ppy Pty Ltd <contact@ppy.sh>. Licensed under the MIT Licence.
 								// See the LICENCE file in the repository root for full licence text.
-												Migrate swells to use nested hitobjects for ticks

											
										
										
											2018-08-03 07:35:29 +00:00
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 15:05:13 +00:00
+								using osu.Game.Rulesets.Judgements;
-												Refactor HitWindows for legibility

											
										
										
											2019-09-06 06:24:00 +00:00
+								using osu.Game.Rulesets.Scoring;
-												Fixed taiko swell hp and scoring

											
										
										
											2018-11-29 15:05:13 +00:00
-												Migrate swells to use nested hitobjects for ticks

											
										
										
											2018-08-03 07:35:29 +00:00
+								namespace osu.Game.Rulesets.Taiko.Objects
 								{
 								    public class SwellTick : TaikoHitObject
 								    {
-												Fix hitobjects with unknown lifetimes by enforcing non-null judgement

We've seen multiple cases where DrawableHitObject are stuck in the lifetime management container
due to not implementing a judgement (meaning they are never "hit" or "missed"). To avoid this going forward
CreateJudgement() must be implemented and return a non-null judgement.

This fixes BananaShower and JuiceStreams in osu!catch.

This also makes HitObject abstract and cleans up convert HitObject implementations.

											
										
										
											2020-02-23 04:01:30 +00:00
+								        public override Judgement CreateJudgement() => new IgnoreJudgement();
-												Return null hitwindows for non-time-based objects

											
										
										
											2019-09-02 07:10:30 +00:00
-												Use empty hitwindows instead of null


											
										
										
											2019-10-09 10:08:31 +00:00
+								        protected override HitWindows CreateHitWindows() => HitWindows.Empty;
-												Migrate swells to use nested hitobjects for ticks

											
										
										
											2018-08-03 07:35:29 +00:00
+								    }
 								}