RepoMirrors
/
osu
mirror of https://github.com/ppy/osu
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
osu/CodeAnalysis/BannedSymbols.txt

Ignoring revisions in .git-blame-ignore-revs. Click here to bypass and see the normal blame view.

26 lines
4.0 KiB
Plaintext
Raw Normal View History

Add BannedApiAnalyzer
2019-11-13 14:29:44 +00:00
M:System.Object.Equals(System.Object,System.Object)~System.Boolean;Don't use object.Equals. Use IEquatable<T> or EqualityComparer<T>.Default instead.
M:System.Object.Equals(System.Object)~System.Boolean;Don't use object.Equals. Use IEquatable<T> or EqualityComparer<T>.Default instead.
M:System.ValueType.Equals(System.Object)~System.Boolean;Don't use object.Equals(Fallbacks to ValueType). Use IEquatable<T> or EqualityComparer<T>.Default instead.
Don't use Equals(object) on T?.
2019-12-03 12:07:22 +00:00
M:System.Nullable`1.Equals(System.Object)~System.Boolean;Use == instead.
Add BannedApiAnalyzer
2019-11-13 14:29:44 +00:00
T:System.IComparable;Don't use non-generic IComparable. Use generic version instead.
Add `IDeepCloneable` interface and update existing `CreateCopy` methods to use it
2021-07-19 03:38:22 +00:00
T:SixLabors.ImageSharp.IDeepCloneable`1;Use osu.Game.Utils.IDeepCloneable<T> instead.
Correct BannedSymbols.txt.
2019-11-25 15:42:59 +00:00
M:osu.Framework.Graphics.Sprites.SpriteText.#ctor;Use OsuSpriteText.
Add IBindableList.GetBoudCopy to banned symbols for now
2020-11-04 06:21:20 +00:00
M:osu.Framework.Bindables.IBindableList`1.GetBoundCopy();Fails on iOS. Use manual ctor + BindTo instead. (see https://github.com/mono/mono/issues/19900)
Add `BannedSymbols` entry for `NuGet.Packaging`
2021-11-23 06:04:44 +00:00
T:NuGet.Packaging.CollectionExtensions;Don't use internal extension methods.
M:System.Enum.HasFlag(System.Enum);Use osu.Framework.Extensions.EnumExtensions.HasFlagFast<T>() instead.
Add `BannedSymbols` rules for `SubscribeForNotifications` variants we use
2021-12-01 06:23:28 +00:00
M:Realms.IRealmCollection`1.SubscribeForNotifications`1(Realms.NotificationCallbackDelegate{``0});Use osu.Game.Database.RealmObjectExtensions.QueryAsyncWithNotifications(IRealmCollection<T>,NotificationCallbackDelegate<T>) instead.
Correctify recommended method and property
2022-05-18 17:38:13 +00:00
M:System.Guid.#ctor;Probably meaning to use Guid.NewGuid() instead. If actually wanting empty, use Guid.Empty.
Add `BannedSymbols` rules for `SubscribeForNotifications` variants we use
2021-12-01 06:23:28 +00:00
M:Realms.CollectionExtensions.SubscribeForNotifications`1(System.Linq.IQueryable{``0},Realms.NotificationCallbackDelegate{``0});Use osu.Game.Database.RealmObjectExtensions.QueryAsyncWithNotifications(IQueryable<T>,NotificationCallbackDelegate<T>) instead.
M:Realms.CollectionExtensions.SubscribeForNotifications`1(System.Collections.Generic.IList{``0},Realms.NotificationCallbackDelegate{``0});Use osu.Game.Database.RealmObjectExtensions.QueryAsyncWithNotifications(IList<T>,NotificationCallbackDelegate<T>) instead.
Replace usages of `Wait` with `WaitSafely`
2022-01-03 08:02:15 +00:00
M:System.Threading.Tasks.Task.Wait();Don't use Task.Wait. Use Task.WaitSafely() to ensure we avoid deadlocks.
Update usages to new naming
2022-01-06 13:54:43 +00:00
P:System.Threading.Tasks.Task`1.Result;Don't use Task.Result. Use Task.GetResultSafely() to ensure we avoid deadlocks.
Ban usage of `ManualResetEventSlim.Wait()` without a timeout value
2022-06-23 05:33:07 +00:00
M:System.Threading.ManualResetEventSlim.Wait();Specify a timeout to avoid waiting forever.
Ban `char.ToLower()`/`char.ToUpper()` as well for better safety
2022-10-21 17:56:18 +00:00
M:System.Char.ToLower(System.Char);char.ToLower() changes behaviour depending on CultureInfo.CurrentCulture. Use char.ToLowerInvariant() instead. If wanting culture-sensitive behaviour, explicitly provide CultureInfo.CurrentCulture.
M:System.Char.ToUpper(System.Char);char.ToUpper() changes behaviour depending on CultureInfo.CurrentCulture. Use char.ToUpperInvariant() instead. If wanting culture-sensitive behaviour, explicitly provide CultureInfo.CurrentCulture.
Replace usages of `string.To{Lower,Upper}()`
2022-06-20 12:39:47 +00:00
M:System.String.ToLower();string.ToLower() changes behaviour depending on CultureInfo.CurrentCulture. Use string.ToLowerInvariant() instead. If wanting culture-sensitive behaviour, explicitly provide CultureInfo.CurrentCulture or use LocalisableString.
M:System.String.ToUpper();string.ToUpper() changes behaviour depending on CultureInfo.CurrentCulture. Use string.ToUpperInvariant() instead. If wanting culture-sensitive behaviour, explicitly provide CultureInfo.CurrentCulture or use LocalisableString.
Replace calls to defective Humanizer methods with correct version
2022-06-20 13:02:15 +00:00
M:Humanizer.InflectorExtensions.Pascalize(System.String);Humanizer's .Pascalize() extension method changes behaviour depending on CultureInfo.CurrentCulture. Use StringDehumanizeExtensions.ToPascalCase() instead.
M:Humanizer.InflectorExtensions.Camelize(System.String);Humanizer's .Camelize() extension method changes behaviour depending on CultureInfo.CurrentCulture. Use StringDehumanizeExtensions.ToCamelCase() instead.
M:Humanizer.InflectorExtensions.Underscore(System.String);Humanizer's .Underscore() extension method changes behaviour depending on CultureInfo.CurrentCulture. Use StringDehumanizeExtensions.ToSnakeCase() instead.
M:Humanizer.InflectorExtensions.Kebaberize(System.String);Humanizer's .Kebaberize() extension method changes behaviour depending on CultureInfo.CurrentCulture. Use StringDehumanizeExtensions.ToKebabCase() instead.