openwrt/package
Robert Marko 856840d953 kernel: qca-ssdk: use bash as shell
Currently, trying to compile qca-ssdk on macOS will fail in a weird way:
make[6]: *** No rule to make target 'openwrt/build_dir/target-aarch64_cortex-a53_musl/linux-qualcommax_ipq807x/qca-ssdk-2024.04.17~3d060f7a/-n',
needed by 'openwrt/build_dir/target-aarch64_cortex-a53_musl/linux-qualcommax_ipq807x/qca-ssdk-2024.04.17~3d060f7a/qca-ssdk.o'. Stop.

After looking looking at src_list.dep from which KBuild cmd_mod will
generate the list of objects to compile it looked like:
-n /src/adpt/adpt.c
-n
-n

Which was rather suspicous so after comparing to the same file but with
Fedora as host:
/src/adpt/adpt.c src/adpt/hppe/adpt_hppe_fdb.c src/adpt/hppe/adpt_hppe_mib.c

It was clear that echo -n which was used in SSDK-s target.mk was not
working as intented, and it looked like the POSIX only version of echo
was being used which does not honor -n.

So, after failling to reproduce it externally, replacing the call to echo
with a full path to coreutils echo fixed the compilation.

After further debugging, it was determined that SSDK does not honor
CONFIG_SHELL like other kernel modules so it was defaulting to /bin/sh as
the shell make was calling thus calling the /bin/sh built-in echo which on
macOS is the old Bash 3.2 one and it does not respect -n.

So, we have to explicitly pass SHELL=$(BASH) to SSDK to make it use bash
like kernel build or other kernel modules.

This is not an issue since on macOS we always build bash anyway.

Link: https://github.com/openwrt/openwrt/pull/15459
Signed-off-by: Robert Marko <robimarko@gmail.com>
2024-05-12 11:38:51 +02:00
..
base-files base-files: fix uid/gid auto-enumeration to avoid 16-bit limit 2024-05-10 22:39:57 +02:00
boot uboot-envtools: ath79: remove env config for Senao Loader devices 2024-05-11 16:57:28 +02:00
devel gperf: build as C++11 2024-05-10 00:11:10 +02:00
firmware ipq-wifi: correct PKG_MIRROR_HASH 2024-04-27 23:29:48 +02:00
kernel kernel: qca-ssdk: use bash as shell 2024-05-12 11:38:51 +02:00
libs mbedtls: export cmake files 2024-05-07 12:50:27 +02:00
network dropbear: clarify DROPBEAR_MODERN_ONLY option 2024-05-09 19:35:36 +02:00
system procd: make mDNS TXT record parsing more solid 2024-04-29 23:24:58 +02:00
utils bcm27xx-utils: update to latest version 2024-05-10 09:17:52 +02:00
Makefile