319 lines
9.6 KiB
Diff
319 lines
9.6 KiB
Diff
From 245c7bc86b198e5ec227eba6b582da73cb0721c8 Mon Sep 17 00:00:00 2001
|
|
From: Lorenzo Bianconi <lorenzo@kernel.org>
|
|
Date: Thu, 1 Aug 2024 16:35:04 +0200
|
|
Subject: [PATCH 2/8] net: airoha: Move airoha_queues in airoha_qdma
|
|
|
|
QDMA controllers available in EN7581 SoC have independent tx/rx hw queues
|
|
so move them in airoha_queues structure.
|
|
|
|
Signed-off-by: Lorenzo Bianconi <lorenzo@kernel.org>
|
|
Link: https://patch.msgid.link/795fc4797bffbf7f0a1351308aa9bf0e65b5126e.1722522582.git.lorenzo@kernel.org
|
|
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
|
|
---
|
|
drivers/net/ethernet/mediatek/airoha_eth.c | 126 +++++++++++----------
|
|
1 file changed, 65 insertions(+), 61 deletions(-)
|
|
|
|
--- a/drivers/net/ethernet/mediatek/airoha_eth.c
|
|
+++ b/drivers/net/ethernet/mediatek/airoha_eth.c
|
|
@@ -785,6 +785,17 @@ struct airoha_hw_stats {
|
|
|
|
struct airoha_qdma {
|
|
void __iomem *regs;
|
|
+
|
|
+ struct airoha_tx_irq_queue q_tx_irq[AIROHA_NUM_TX_IRQ];
|
|
+
|
|
+ struct airoha_queue q_tx[AIROHA_NUM_TX_RING];
|
|
+ struct airoha_queue q_rx[AIROHA_NUM_RX_RING];
|
|
+
|
|
+ /* descriptor and packet buffers for qdma hw forward */
|
|
+ struct {
|
|
+ void *desc;
|
|
+ void *q;
|
|
+ } hfwd;
|
|
};
|
|
|
|
struct airoha_gdm_port {
|
|
@@ -809,20 +820,10 @@ struct airoha_eth {
|
|
struct reset_control_bulk_data rsts[AIROHA_MAX_NUM_RSTS];
|
|
struct reset_control_bulk_data xsi_rsts[AIROHA_MAX_NUM_XSI_RSTS];
|
|
|
|
- struct airoha_qdma qdma[AIROHA_MAX_NUM_QDMA];
|
|
- struct airoha_gdm_port *ports[AIROHA_MAX_NUM_GDM_PORTS];
|
|
-
|
|
struct net_device *napi_dev;
|
|
- struct airoha_queue q_tx[AIROHA_NUM_TX_RING];
|
|
- struct airoha_queue q_rx[AIROHA_NUM_RX_RING];
|
|
-
|
|
- struct airoha_tx_irq_queue q_tx_irq[AIROHA_NUM_TX_IRQ];
|
|
|
|
- /* descriptor and packet buffers for qdma hw forward */
|
|
- struct {
|
|
- void *desc;
|
|
- void *q;
|
|
- } hfwd;
|
|
+ struct airoha_qdma qdma[AIROHA_MAX_NUM_QDMA];
|
|
+ struct airoha_gdm_port *ports[AIROHA_MAX_NUM_GDM_PORTS];
|
|
};
|
|
|
|
static u32 airoha_rr(void __iomem *base, u32 offset)
|
|
@@ -1390,7 +1391,7 @@ static int airoha_qdma_fill_rx_queue(str
|
|
enum dma_data_direction dir = page_pool_get_dma_dir(q->page_pool);
|
|
struct airoha_qdma *qdma = &q->eth->qdma[0];
|
|
struct airoha_eth *eth = q->eth;
|
|
- int qid = q - ð->q_rx[0];
|
|
+ int qid = q - &qdma->q_rx[0];
|
|
int nframes = 0;
|
|
|
|
while (q->queued < q->ndesc - 1) {
|
|
@@ -1457,8 +1458,9 @@ static int airoha_qdma_get_gdm_port(stru
|
|
static int airoha_qdma_rx_process(struct airoha_queue *q, int budget)
|
|
{
|
|
enum dma_data_direction dir = page_pool_get_dma_dir(q->page_pool);
|
|
+ struct airoha_qdma *qdma = &q->eth->qdma[0];
|
|
struct airoha_eth *eth = q->eth;
|
|
- int qid = q - ð->q_rx[0];
|
|
+ int qid = q - &qdma->q_rx[0];
|
|
int done = 0;
|
|
|
|
while (done < budget) {
|
|
@@ -1550,7 +1552,7 @@ static int airoha_qdma_init_rx_queue(str
|
|
.dev = eth->dev,
|
|
.napi = &q->napi,
|
|
};
|
|
- int qid = q - ð->q_rx[0], thr;
|
|
+ int qid = q - &qdma->q_rx[0], thr;
|
|
dma_addr_t dma_addr;
|
|
|
|
q->buf_size = PAGE_SIZE / 2;
|
|
@@ -1614,7 +1616,7 @@ static int airoha_qdma_init_rx(struct ai
|
|
{
|
|
int i;
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_rx); i++) {
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_rx); i++) {
|
|
int err;
|
|
|
|
if (!(RX_DONE_INT_MASK & BIT(i))) {
|
|
@@ -1622,7 +1624,7 @@ static int airoha_qdma_init_rx(struct ai
|
|
continue;
|
|
}
|
|
|
|
- err = airoha_qdma_init_rx_queue(eth, ð->q_rx[i],
|
|
+ err = airoha_qdma_init_rx_queue(eth, &qdma->q_rx[i],
|
|
qdma, RX_DSCP_NUM(i));
|
|
if (err)
|
|
return err;
|
|
@@ -1641,7 +1643,7 @@ static int airoha_qdma_tx_napi_poll(stru
|
|
irq_q = container_of(napi, struct airoha_tx_irq_queue, napi);
|
|
eth = irq_q->eth;
|
|
qdma = ð->qdma[0];
|
|
- id = irq_q - ð->q_tx_irq[0];
|
|
+ id = irq_q - &qdma->q_tx_irq[0];
|
|
|
|
while (irq_q->queued > 0 && done < budget) {
|
|
u32 qid, last, val = irq_q->q[irq_q->head];
|
|
@@ -1658,10 +1660,10 @@ static int airoha_qdma_tx_napi_poll(stru
|
|
last = FIELD_GET(IRQ_DESC_IDX_MASK, val);
|
|
qid = FIELD_GET(IRQ_RING_IDX_MASK, val);
|
|
|
|
- if (qid >= ARRAY_SIZE(eth->q_tx))
|
|
+ if (qid >= ARRAY_SIZE(qdma->q_tx))
|
|
continue;
|
|
|
|
- q = ð->q_tx[qid];
|
|
+ q = &qdma->q_tx[qid];
|
|
if (!q->ndesc)
|
|
continue;
|
|
|
|
@@ -1727,7 +1729,7 @@ static int airoha_qdma_init_tx_queue(str
|
|
struct airoha_queue *q,
|
|
struct airoha_qdma *qdma, int size)
|
|
{
|
|
- int i, qid = q - ð->q_tx[0];
|
|
+ int i, qid = q - &qdma->q_tx[0];
|
|
dma_addr_t dma_addr;
|
|
|
|
spin_lock_init(&q->lock);
|
|
@@ -1765,7 +1767,7 @@ static int airoha_qdma_tx_irq_init(struc
|
|
struct airoha_tx_irq_queue *irq_q,
|
|
struct airoha_qdma *qdma, int size)
|
|
{
|
|
- int id = irq_q - ð->q_tx_irq[0];
|
|
+ int id = irq_q - &qdma->q_tx_irq[0];
|
|
dma_addr_t dma_addr;
|
|
|
|
netif_napi_add_tx(eth->napi_dev, &irq_q->napi,
|
|
@@ -1793,15 +1795,15 @@ static int airoha_qdma_init_tx(struct ai
|
|
{
|
|
int i, err;
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++) {
|
|
- err = airoha_qdma_tx_irq_init(eth, ð->q_tx_irq[i],
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx_irq); i++) {
|
|
+ err = airoha_qdma_tx_irq_init(eth, &qdma->q_tx_irq[i],
|
|
qdma, IRQ_QUEUE_LEN(i));
|
|
if (err)
|
|
return err;
|
|
}
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++) {
|
|
- err = airoha_qdma_init_tx_queue(eth, ð->q_tx[i],
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx); i++) {
|
|
+ err = airoha_qdma_init_tx_queue(eth, &qdma->q_tx[i],
|
|
qdma, TX_DSCP_NUM);
|
|
if (err)
|
|
return err;
|
|
@@ -1837,17 +1839,17 @@ static int airoha_qdma_init_hfwd_queues(
|
|
int size;
|
|
|
|
size = HW_DSCP_NUM * sizeof(struct airoha_qdma_fwd_desc);
|
|
- eth->hfwd.desc = dmam_alloc_coherent(eth->dev, size, &dma_addr,
|
|
- GFP_KERNEL);
|
|
- if (!eth->hfwd.desc)
|
|
+ qdma->hfwd.desc = dmam_alloc_coherent(eth->dev, size, &dma_addr,
|
|
+ GFP_KERNEL);
|
|
+ if (!qdma->hfwd.desc)
|
|
return -ENOMEM;
|
|
|
|
airoha_qdma_wr(qdma, REG_FWD_DSCP_BASE, dma_addr);
|
|
|
|
size = AIROHA_MAX_PACKET_SIZE * HW_DSCP_NUM;
|
|
- eth->hfwd.q = dmam_alloc_coherent(eth->dev, size, &dma_addr,
|
|
- GFP_KERNEL);
|
|
- if (!eth->hfwd.q)
|
|
+ qdma->hfwd.q = dmam_alloc_coherent(eth->dev, size, &dma_addr,
|
|
+ GFP_KERNEL);
|
|
+ if (!qdma->hfwd.q)
|
|
return -ENOMEM;
|
|
|
|
airoha_qdma_wr(qdma, REG_FWD_BUF_BASE, dma_addr);
|
|
@@ -1935,8 +1937,8 @@ static int airoha_qdma_hw_init(struct ai
|
|
airoha_qdma_irq_enable(eth, QDMA_INT_REG_IDX4, INT_IDX4_MASK);
|
|
|
|
/* setup irq binding */
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++) {
|
|
- if (!eth->q_tx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx); i++) {
|
|
+ if (!qdma->q_tx[i].ndesc)
|
|
continue;
|
|
|
|
if (TX_RING_IRQ_BLOCKING_MAP_MASK & BIT(i))
|
|
@@ -1961,8 +1963,8 @@ static int airoha_qdma_hw_init(struct ai
|
|
airoha_qdma_init_qos(eth, qdma);
|
|
|
|
/* disable qdma rx delay interrupt */
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_rx); i++) {
|
|
- if (!eth->q_rx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_rx); i++) {
|
|
+ if (!qdma->q_rx[i].ndesc)
|
|
continue;
|
|
|
|
airoha_qdma_clear(qdma, REG_RX_DELAY_INT_IDX(i),
|
|
@@ -1996,18 +1998,18 @@ static irqreturn_t airoha_irq_handler(in
|
|
airoha_qdma_irq_disable(eth, QDMA_INT_REG_IDX1,
|
|
RX_DONE_INT_MASK);
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_rx); i++) {
|
|
- if (!eth->q_rx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_rx); i++) {
|
|
+ if (!qdma->q_rx[i].ndesc)
|
|
continue;
|
|
|
|
if (intr[1] & BIT(i))
|
|
- napi_schedule(ð->q_rx[i].napi);
|
|
+ napi_schedule(&qdma->q_rx[i].napi);
|
|
}
|
|
}
|
|
|
|
if (intr[0] & INT_TX_MASK) {
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++) {
|
|
- struct airoha_tx_irq_queue *irq_q = ð->q_tx_irq[i];
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx_irq); i++) {
|
|
+ struct airoha_tx_irq_queue *irq_q = &qdma->q_tx_irq[i];
|
|
u32 status, head;
|
|
|
|
if (!(intr[0] & TX_DONE_INT_MASK(i)))
|
|
@@ -2021,7 +2023,7 @@ static irqreturn_t airoha_irq_handler(in
|
|
irq_q->head = head % irq_q->size;
|
|
irq_q->queued = FIELD_GET(IRQ_ENTRY_LEN_MASK, status);
|
|
|
|
- napi_schedule(ð->q_tx_irq[i].napi);
|
|
+ napi_schedule(&qdma->q_tx_irq[i].napi);
|
|
}
|
|
}
|
|
|
|
@@ -2080,44 +2082,46 @@ static int airoha_hw_init(struct airoha_
|
|
|
|
static void airoha_hw_cleanup(struct airoha_eth *eth)
|
|
{
|
|
+ struct airoha_qdma *qdma = ð->qdma[0];
|
|
int i;
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_rx); i++) {
|
|
- if (!eth->q_rx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_rx); i++) {
|
|
+ if (!qdma->q_rx[i].ndesc)
|
|
continue;
|
|
|
|
- napi_disable(ð->q_rx[i].napi);
|
|
- netif_napi_del(ð->q_rx[i].napi);
|
|
- airoha_qdma_cleanup_rx_queue(ð->q_rx[i]);
|
|
- if (eth->q_rx[i].page_pool)
|
|
- page_pool_destroy(eth->q_rx[i].page_pool);
|
|
+ napi_disable(&qdma->q_rx[i].napi);
|
|
+ netif_napi_del(&qdma->q_rx[i].napi);
|
|
+ airoha_qdma_cleanup_rx_queue(&qdma->q_rx[i]);
|
|
+ if (qdma->q_rx[i].page_pool)
|
|
+ page_pool_destroy(qdma->q_rx[i].page_pool);
|
|
}
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++) {
|
|
- napi_disable(ð->q_tx_irq[i].napi);
|
|
- netif_napi_del(ð->q_tx_irq[i].napi);
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx_irq); i++) {
|
|
+ napi_disable(&qdma->q_tx_irq[i].napi);
|
|
+ netif_napi_del(&qdma->q_tx_irq[i].napi);
|
|
}
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx); i++) {
|
|
- if (!eth->q_tx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx); i++) {
|
|
+ if (!qdma->q_tx[i].ndesc)
|
|
continue;
|
|
|
|
- airoha_qdma_cleanup_tx_queue(ð->q_tx[i]);
|
|
+ airoha_qdma_cleanup_tx_queue(&qdma->q_tx[i]);
|
|
}
|
|
}
|
|
|
|
static void airoha_qdma_start_napi(struct airoha_eth *eth)
|
|
{
|
|
+ struct airoha_qdma *qdma = ð->qdma[0];
|
|
int i;
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_tx_irq); i++)
|
|
- napi_enable(ð->q_tx_irq[i].napi);
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_tx_irq); i++)
|
|
+ napi_enable(&qdma->q_tx_irq[i].napi);
|
|
|
|
- for (i = 0; i < ARRAY_SIZE(eth->q_rx); i++) {
|
|
- if (!eth->q_rx[i].ndesc)
|
|
+ for (i = 0; i < ARRAY_SIZE(qdma->q_rx); i++) {
|
|
+ if (!qdma->q_rx[i].ndesc)
|
|
continue;
|
|
|
|
- napi_enable(ð->q_rx[i].napi);
|
|
+ napi_enable(&qdma->q_rx[i].napi);
|
|
}
|
|
}
|
|
|
|
@@ -2392,7 +2396,7 @@ static netdev_tx_t airoha_dev_xmit(struc
|
|
FIELD_PREP(QDMA_ETH_TXMSG_METER_MASK, 0x7f);
|
|
|
|
qdma = ð->qdma[0];
|
|
- q = ð->q_tx[qid];
|
|
+ q = &qdma->q_tx[qid];
|
|
if (WARN_ON_ONCE(!q->ndesc))
|
|
goto error;
|
|
|