generic: rtl8366: introduce rtl8366_smi_alloc

SVN-Revision: 22195
This commit is contained in:
Gabor Juhos 2010-07-15 13:05:16 +00:00
parent c7bc8fb46c
commit b093cec6cc
4 changed files with 20 additions and 9 deletions

View File

@ -741,13 +741,27 @@ static void rtl8366_smi_mii_cleanup(struct rtl8366_smi *smi)
mdiobus_free(smi->mii_bus);
}
struct rtl8366_smi *rtl8366_smi_alloc(struct device *parent)
{
struct rtl8366_smi *smi;
BUG_ON(!parent);
smi = kzalloc(sizeof(*smi), GFP_KERNEL);
if (!smi) {
dev_err(parent, "no memory for private data\n");
return NULL;
}
smi->parent = parent;
return smi;
}
EXPORT_SYMBOL_GPL(rtl8366_smi_alloc);
int rtl8366_smi_init(struct rtl8366_smi *smi)
{
int err;
if (!smi->parent)
return -EINVAL;
if (!smi->ops)
return -EINVAL;

View File

@ -87,6 +87,7 @@ struct rtl8366_smi_ops {
int port, unsigned long long *val);
};
struct rtl8366_smi *rtl8366_smi_alloc(struct device *parent);
int rtl8366_smi_init(struct rtl8366_smi *smi);
void rtl8366_smi_cleanup(struct rtl8366_smi *smi);
int rtl8366_smi_write_reg(struct rtl8366_smi *smi, u32 addr, u32 data);

View File

@ -1133,14 +1133,12 @@ static int __init rtl8366rb_probe(struct platform_device *pdev)
goto err_out;
}
smi = kzalloc(sizeof(*smi), GFP_KERNEL);
smi = rtl8366_smi_alloc(&pdev->dev);
if (!smi) {
dev_err(&pdev->dev, "no memory for private data\n");
err = -ENOMEM;
goto err_out;
}
smi->parent = &pdev->dev;
smi->gpio_sda = pdata->gpio_sda;
smi->gpio_sck = pdata->gpio_sck;
smi->ops = &rtl8366rb_smi_ops;

View File

@ -1160,14 +1160,12 @@ static int __init rtl8366s_probe(struct platform_device *pdev)
goto err_out;
}
smi = kzalloc(sizeof(*smi), GFP_KERNEL);
smi = rtl8366_smi_alloc(&pdev->dev);
if (!smi) {
dev_err(&pdev->dev, "no memory for private data\n");
err = -ENOMEM;
goto err_out;
}
smi->parent = &pdev->dev;
smi->gpio_sda = pdata->gpio_sda;
smi->gpio_sck = pdata->gpio_sck;
smi->ops = &rtl8366s_smi_ops;