RepoMirrors/openwrt
1
0
Fork 0
mirror of git://git.openwrt.org/openwrt/openwrt.git synced 2024-12-13 10:24:51 +00:00
Code Issues Packages Projects Releases Wiki Activity

b43: work around a locking issue, might fix #5996

Browse Source 
SVN-Revision: 18338
This commit is contained in:
Felix Fietkau 2009-11-07 17:40:52 +00:00
parent 2e72f3b269
commit ae0457f76a
1 changed files with 23 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
package/mac80211/patches/405-b43_locking_fix.patch Normal file
View File

@ -0,0 +1,23 @@
Subject: [PATCH] b43: work around a locking issue in ->set_tim()
ops->set_tim() must be atomic, so b43 trying to acquire a mutex leads
to a kernel crash. This patch trades an easy to trigger crash in AP
mode for an unlikely race condition. According to Michael, the real
fix would be to allow set_tim() callbacks to sleep, since b43 is
not the only driver that needs to sleep in all callbacks.
Signed-off-by: Felix Fietkau <nbd@openwrt.org>
--- a/drivers/net/wireless/b43/main.c
+++ b/drivers/net/wireless/b43/main.c
@@ -4534,9 +4534,8 @@ static int b43_op_beacon_set_tim(struct
{
struct b43_wl *wl = hw_to_b43_wl(hw);
- mutex_lock(&wl->mutex);
+ /* FIXME: add locking */
b43_update_templates(wl);
- mutex_unlock(&wl->mutex);
return 0;
}