RepoMirrors
/
openwrt
mirror of git://git.openwrt.org/openwrt/openwrt.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

config: select KERNEL_WERROR if building with default GCC version 

At the moment we have to manually follow the default GCC version
also in config/Config-kernel.in. This tends to be forgotten at GCC
version bumps (just happened when switching from version 12 to 13).
Instead, introduce a hidden Kconfig symbol which implies KERNEL_WERROR
in toolchain/gcc/Config.in where it is visible for developers changing
the default version.

Also remove the explicit default on BUILDBOT to avoid a circular
dependency and also because buildbots anyway implicitly always select
the default GCC version.

Reference: https://github.com/openwrt/openwrt/pull/15064
Signed-off-by: Daniel Golle <daniel@makrotopia.org>
This commit is contained in:
Daniel Golle 2024-04-07 19:50:04 +01:00
parent 5e0587b8d1
commit 501ef81040
2 changed files with 5 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
config/Config-kernel.in
View File

@ -1418,8 +1418,6 @@ config KERNEL_JFFS2_FS_SECURITY
config KERNEL_WERROR config KERNEL_WERROR
bool "Compile the kernel with warnings as errors" bool "Compile the kernel with warnings as errors"
default BUILDBOT
default y if GCC_USE_VERSION_12
help help
A kernel build should not cause any compiler warnings, and this A kernel build should not cause any compiler warnings, and this
enables the '-Werror' (for C) and '-Dwarnings' (for Rust) flags enables the '-Werror' (for C) and '-Dwarnings' (for Rust) flags

5
toolchain/gcc/Config.in
View File

@ -16,6 +16,11 @@ choice
bool "gcc 13.x" bool "gcc 13.x"
endchoice endchoice
config GCC_USE_DEFAULT_VERSION
bool
default y if !TOOLCHAINOPTS || GCC_USE_VERSION_13
imply KERNEL_WERROR
config GCC_USE_GRAPHITE config GCC_USE_GRAPHITE
bool bool
prompt "Compile in support for the new Graphite framework in GCC 4.4+" if TOOLCHAINOPTS prompt "Compile in support for the new Graphite framework in GCC 4.4+" if TOOLCHAINOPTS