From 1a55a2b1121106063fa1896d35340e638b7e2e3d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Rafa=C5=82=20Mi=C5=82ecki?= <rafal@milecki.pl>
Date: Fri, 9 Apr 2021 00:12:28 +0200
Subject: [PATCH] firmware-utils: add -Wall to most tools
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

This helps spotting possible problems

Signed-off-by: Rafał Miłecki <rafal@milecki.pl>
---
 tools/firmware-utils/Makefile | 86 +++++++++++++++++------------------
 1 file changed, 43 insertions(+), 43 deletions(-)

diff --git a/tools/firmware-utils/Makefile b/tools/firmware-utils/Makefile
index 28f8f0555a..285722c3c2 100644
--- a/tools/firmware-utils/Makefile
+++ b/tools/firmware-utils/Makefile
@@ -24,80 +24,80 @@ endef
 
 define Host/Compile
 	mkdir -p $(HOST_BUILD_DIR)/bin
-	$(call cc,add_header)
-	$(call cc,addpattern)
-	$(call cc,asustrx)
+	$(call cc,add_header,-Wall)
+	$(call cc,addpattern,-Wall)
+	$(call cc,asustrx,-Wall)
 	$(call cc,bcm4908asus,-Wall)
 	$(call cc,bcm4908kernel,-Wall)
 	$(call cc,buffalo-enc buffalo-lib,-Wall)
 	$(call cc,buffalo-tag buffalo-lib,-Wall)
 	$(call cc,buffalo-tftp buffalo-lib,-Wall)
-	$(call cc,dgfirmware)
+	$(call cc,dgfirmware,-Wall)
 	$(call cc,dgn3500sum,-Wall)
 	$(call cc,dns313-header,-Wall)
 	$(call cc,edimax_fw_header,-Wall)
-	$(call cc,encode_crc)
+	$(call cc,encode_crc,-Wall)
 	$(call cc,fix-u-media-header cyg_crc32,-Wall)
-	$(call cc,hcsmakeimage bcmalgo)
-	$(call cc,imagetag imagetag_cmdline cyg_crc32)
+	$(call cc,hcsmakeimage bcmalgo,-Wall)
+	$(call cc,imagetag imagetag_cmdline cyg_crc32,-Wall)
 	$(call cc,jcgimage,-lz -Wall)
-	$(call cc,lxlfw)
-	$(call cc,lzma2eva,-lz)
-	$(call cc,makeamitbin)
-	$(call cc,mkbrncmdline)
-	$(call cc,mkbrnimg)
+	$(call cc,lxlfw,-Wall)
+	$(call cc,lzma2eva,-lz -Wall)
+	$(call cc,makeamitbin,-Wall)
+	$(call cc,mkbrncmdline,-Wall)
+	$(call cc,mkbrnimg,-Wall)
 	$(call cc,mkbuffaloimg,-Wall)
 	$(call cc,mkcameofw,-Wall)
-	$(call cc,mkcasfw)
-	$(call cc,mkchkimg)
-	$(call cc,mkcsysimg)
-	$(call cc,mkdapimg)
-	$(call cc,mkdapimg2)
+	$(call cc,mkcasfw,-Wall)
+	$(call cc,mkchkimg,-Wall)
+	$(call cc,mkcsysimg,-Wall)
+	$(call cc,mkdapimg,-Wall)
+	$(call cc,mkdapimg2,-Wall)
 	$(call cc,mkdhpimg buffalo-lib,-Wall)
 	$(call cc,mkdlinkfw mkdlinkfw-lib,-lz -Wall --std=c99)
-	$(call cc,mkdniimg)
-	$(call cc,mkedimaximg)
+	$(call cc,mkdniimg,-Wall)
+	$(call cc,mkedimaximg,-Wall)
 	$(call cc,mkfwimage,-lz -Wall -Werror -Wextra -D_FILE_OFFSET_BITS=64)
-	$(call cc,mkfwimage2,-lz)
-	$(call cc,mkheader_gemtek,-lz)
-	$(call cc,mkhilinkfw,-lcrypto)
+	$(call cc,mkfwimage2,-lz -Wall)
+	$(call cc,mkheader_gemtek,-lz -Wall)
+	$(call cc,mkhilinkfw,-lcrypto -Wall)
 	$(call cc,mkmerakifw sha1,-Wall)
 	$(call cc,mkmerakifw-old,-Wall)
-	$(call cc,mkmylofw)
-	$(call cc,mkplanexfw sha1)
+	$(call cc,mkmylofw,-Wall)
+	$(call cc,mkplanexfw sha1,-Wall)
 	$(call cc,mkporayfw,-Wall)
-	$(call cc,mkrasimage,--std=gnu99)
-	$(call cc,mkrtn56uimg,-lz)
+	$(call cc,mkrasimage,--std=gnu99 -Wall)
+	$(call cc,mkrtn56uimg,-lz -Wall)
 	$(call cc,mksenaofw md5,-Wall --std=gnu99)
 	$(call cc,mksercommfw,-Wall)
-	$(call cc,mktitanimg)
+	$(call cc,mktitanimg,-Wall)
 	$(call cc,mktplinkfw mktplinkfw-lib md5,-Wall -fgnu89-inline)
-	$(call cc,mktplinkfw2 mktplinkfw-lib md5,-fgnu89-inline)
+	$(call cc,mktplinkfw2 mktplinkfw-lib md5,-Wall -fgnu89-inline)
 	$(call cc,mkwrggimg md5,-Wall)
 	$(call cc,mkwrgimg md5,-Wall)
-	$(call cc,mkzcfw cyg_crc32)
-	$(call cc,mkzynfw)
-	$(call cc,motorola-bin)
-	$(call cc,nand_ecc)
+	$(call cc,mkzcfw cyg_crc32,-Wall)
+	$(call cc,mkzynfw,-Wall)
+	$(call cc,motorola-bin,-Wall)
+	$(call cc,nand_ecc,-Wall)
 	$(call cc,nec-enc,-Wall --std=gnu99)
-	$(call cc,osbridge-crc)
+	$(call cc,osbridge-crc,-Wall)
 	$(call cc,oseama md5,-Wall)
-	$(call cc,otrx)
+	$(call cc,otrx,-Wall)
 	$(call cc,pc1crypt)
-	$(call cc,ptgen cyg_crc32)
-	$(call cc,seama md5)
+	$(call cc,ptgen cyg_crc32,-Wall)
+	$(call cc,seama md5,-Wall)
 	$(call cc,sign_dlink_ru md5,-Wall)
-	$(call cc,spw303v)
+	$(call cc,spw303v,-Wall)
 	$(call cc,srec2bin)
 	$(call cc,tplink-safeloader md5,-Wall --std=gnu99)
-	$(call cc,trx)
-	$(call cc,trx2edips)
-	$(call cc,trx2usr)
+	$(call cc,trx,-Wall)
+	$(call cc,trx2edips,-Wall)
+	$(call cc,trx2usr,-Wall)
 	$(call cc,uimage_padhdr,-Wall -lz)
-	$(call cc,wrt400n cyg_crc32)
-	$(call cc,xorimage)
+	$(call cc,wrt400n cyg_crc32,-Wall)
+	$(call cc,xorimage,-Wall)
 	$(call cc,zyimage,-Wall)
-	$(call cc,zyxbcm)
+	$(call cc,zyxbcm,-Wall)
 endef
 
 define Host/Install