From 0ed72c271b13078d2daff45349368ed80d4a1fd5 Mon Sep 17 00:00:00 2001 From: Robert Marko Date: Sat, 22 Jun 2024 21:57:23 +0200 Subject: [PATCH] uml: fix glibc-static check with GCC14 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Running the glibc-static check with GCC14 as the host compiler will fail: Please install a static glibc package. (Missing libutil.a, librt.a or libpthread.a) However, this error will get printed even with the required static libraries installed when GCC14 is used. Manually running the check exposes the real error: : In function ‘main’: :1:45: error: implicit declaration of function ‘timer_gettime’ [-Wimplicit-function-declaration] GCC14 now errors on implicit declarations by default, so lets add the required time.h header to fix compilation and thus the check. Link: https://github.com/openwrt/openwrt/pull/15778 Signed-off-by: Robert Marko --- target/linux/uml/image/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target/linux/uml/image/Makefile b/target/linux/uml/image/Makefile index 45ab0cfbcd..f00ccab0e4 100644 --- a/target/linux/uml/image/Makefile +++ b/target/linux/uml/image/Makefile @@ -30,4 +30,4 @@ $(eval $(call BuildImage)) $(eval $(call TestHostCommand,glibc-static, \ Please install a static glibc package. (Missing libutil.a, librt.a or libpthread.a), \ echo 'int main(int argc, char **argv) { login(0); timer_gettime(0, 0); return 0; }' | \ - gcc -include utmp.h -x c -o $(TMP_DIR)/a.out - -static -lutil -lrt)) + gcc -include utmp.h -include time.h -x c -o $(TMP_DIR)/a.out - -static -lutil -lrt))