mirror of
git://anongit.mindrot.org/openssh.git
synced 2024-12-25 19:32:09 +00:00
7cd31632e3
Remove all guards for calls to OpenSSL free functions - all of these functions handle NULL, from at least OpenSSL 1.0.1g onwards. Prompted by dtucker@ asking about guards for RSA_free(), when looking at openssh-portable pr#84 on github. ok deraadt@ dtucker@ OpenBSD-Commit-ID: 954f1c51b94297d0ae1f749271e184141e0cadae
218 lines
6.0 KiB
C
218 lines
6.0 KiB
C
/* $OpenBSD: kexdhc.c,v 1.22 2018/02/07 02:06:51 jsing Exp $ */
|
|
/*
|
|
* Copyright (c) 2001 Markus Friedl. All rights reserved.
|
|
*
|
|
* Redistribution and use in source and binary forms, with or without
|
|
* modification, are permitted provided that the following conditions
|
|
* are met:
|
|
* 1. Redistributions of source code must retain the above copyright
|
|
* notice, this list of conditions and the following disclaimer.
|
|
* 2. Redistributions in binary form must reproduce the above copyright
|
|
* notice, this list of conditions and the following disclaimer in the
|
|
* documentation and/or other materials provided with the distribution.
|
|
*
|
|
* THIS SOFTWARE IS PROVIDED BY THE AUTHOR ``AS IS'' AND ANY EXPRESS OR
|
|
* IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE IMPLIED WARRANTIES
|
|
* OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE DISCLAIMED.
|
|
* IN NO EVENT SHALL THE AUTHOR BE LIABLE FOR ANY DIRECT, INDIRECT,
|
|
* INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES (INCLUDING, BUT
|
|
* NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; LOSS OF USE,
|
|
* DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON ANY
|
|
* THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
|
|
* (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF
|
|
* THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
|
|
*/
|
|
|
|
#include "includes.h"
|
|
|
|
#ifdef WITH_OPENSSL
|
|
|
|
#include <sys/types.h>
|
|
|
|
#include <openssl/dh.h>
|
|
|
|
#include <stdarg.h>
|
|
#include <stdio.h>
|
|
#include <string.h>
|
|
#include <signal.h>
|
|
|
|
#include "sshkey.h"
|
|
#include "cipher.h"
|
|
#include "digest.h"
|
|
#include "kex.h"
|
|
#include "log.h"
|
|
#include "packet.h"
|
|
#include "dh.h"
|
|
#include "ssh2.h"
|
|
#include "dispatch.h"
|
|
#include "compat.h"
|
|
#include "ssherr.h"
|
|
#include "sshbuf.h"
|
|
|
|
static int input_kex_dh(int, u_int32_t, struct ssh *);
|
|
|
|
int
|
|
kexdh_client(struct ssh *ssh)
|
|
{
|
|
struct kex *kex = ssh->kex;
|
|
int r;
|
|
|
|
/* generate and send 'e', client DH public key */
|
|
switch (kex->kex_type) {
|
|
case KEX_DH_GRP1_SHA1:
|
|
kex->dh = dh_new_group1();
|
|
break;
|
|
case KEX_DH_GRP14_SHA1:
|
|
case KEX_DH_GRP14_SHA256:
|
|
kex->dh = dh_new_group14();
|
|
break;
|
|
case KEX_DH_GRP16_SHA512:
|
|
kex->dh = dh_new_group16();
|
|
break;
|
|
case KEX_DH_GRP18_SHA512:
|
|
kex->dh = dh_new_group18();
|
|
break;
|
|
default:
|
|
r = SSH_ERR_INVALID_ARGUMENT;
|
|
goto out;
|
|
}
|
|
if (kex->dh == NULL) {
|
|
r = SSH_ERR_ALLOC_FAIL;
|
|
goto out;
|
|
}
|
|
debug("sending SSH2_MSG_KEXDH_INIT");
|
|
if ((r = dh_gen_key(kex->dh, kex->we_need * 8)) != 0 ||
|
|
(r = sshpkt_start(ssh, SSH2_MSG_KEXDH_INIT)) != 0 ||
|
|
(r = sshpkt_put_bignum2(ssh, kex->dh->pub_key)) != 0 ||
|
|
(r = sshpkt_send(ssh)) != 0)
|
|
goto out;
|
|
#ifdef DEBUG_KEXDH
|
|
DHparams_print_fp(stderr, kex->dh);
|
|
fprintf(stderr, "pub= ");
|
|
BN_print_fp(stderr, kex->dh->pub_key);
|
|
fprintf(stderr, "\n");
|
|
#endif
|
|
debug("expecting SSH2_MSG_KEXDH_REPLY");
|
|
ssh_dispatch_set(ssh, SSH2_MSG_KEXDH_REPLY, &input_kex_dh);
|
|
r = 0;
|
|
out:
|
|
return r;
|
|
}
|
|
|
|
static int
|
|
input_kex_dh(int type, u_int32_t seq, struct ssh *ssh)
|
|
{
|
|
struct kex *kex = ssh->kex;
|
|
BIGNUM *dh_server_pub = NULL, *shared_secret = NULL;
|
|
struct sshkey *server_host_key = NULL;
|
|
u_char *kbuf = NULL, *server_host_key_blob = NULL, *signature = NULL;
|
|
u_char hash[SSH_DIGEST_MAX_LENGTH];
|
|
size_t klen = 0, slen, sbloblen, hashlen;
|
|
int kout, r;
|
|
|
|
if (kex->verify_host_key == NULL) {
|
|
r = SSH_ERR_INVALID_ARGUMENT;
|
|
goto out;
|
|
}
|
|
/* key, cert */
|
|
if ((r = sshpkt_get_string(ssh, &server_host_key_blob,
|
|
&sbloblen)) != 0 ||
|
|
(r = sshkey_from_blob(server_host_key_blob, sbloblen,
|
|
&server_host_key)) != 0)
|
|
goto out;
|
|
if (server_host_key->type != kex->hostkey_type ||
|
|
(kex->hostkey_type == KEY_ECDSA &&
|
|
server_host_key->ecdsa_nid != kex->hostkey_nid)) {
|
|
r = SSH_ERR_KEY_TYPE_MISMATCH;
|
|
goto out;
|
|
}
|
|
if (kex->verify_host_key(server_host_key, ssh) == -1) {
|
|
r = SSH_ERR_SIGNATURE_INVALID;
|
|
goto out;
|
|
}
|
|
/* DH parameter f, server public DH key */
|
|
if ((dh_server_pub = BN_new()) == NULL) {
|
|
r = SSH_ERR_ALLOC_FAIL;
|
|
goto out;
|
|
}
|
|
/* signed H */
|
|
if ((r = sshpkt_get_bignum2(ssh, dh_server_pub)) != 0 ||
|
|
(r = sshpkt_get_string(ssh, &signature, &slen)) != 0 ||
|
|
(r = sshpkt_get_end(ssh)) != 0)
|
|
goto out;
|
|
#ifdef DEBUG_KEXDH
|
|
fprintf(stderr, "dh_server_pub= ");
|
|
BN_print_fp(stderr, dh_server_pub);
|
|
fprintf(stderr, "\n");
|
|
debug("bits %d", BN_num_bits(dh_server_pub));
|
|
#endif
|
|
if (!dh_pub_is_valid(kex->dh, dh_server_pub)) {
|
|
sshpkt_disconnect(ssh, "bad server public DH value");
|
|
r = SSH_ERR_MESSAGE_INCOMPLETE;
|
|
goto out;
|
|
}
|
|
|
|
klen = DH_size(kex->dh);
|
|
if ((kbuf = malloc(klen)) == NULL ||
|
|
(shared_secret = BN_new()) == NULL) {
|
|
r = SSH_ERR_ALLOC_FAIL;
|
|
goto out;
|
|
}
|
|
if ((kout = DH_compute_key(kbuf, dh_server_pub, kex->dh)) < 0 ||
|
|
BN_bin2bn(kbuf, kout, shared_secret) == NULL) {
|
|
r = SSH_ERR_LIBCRYPTO_ERROR;
|
|
goto out;
|
|
}
|
|
#ifdef DEBUG_KEXDH
|
|
dump_digest("shared secret", kbuf, kout);
|
|
#endif
|
|
|
|
/* calc and verify H */
|
|
hashlen = sizeof(hash);
|
|
if ((r = kex_dh_hash(
|
|
kex->hash_alg,
|
|
kex->client_version_string,
|
|
kex->server_version_string,
|
|
sshbuf_ptr(kex->my), sshbuf_len(kex->my),
|
|
sshbuf_ptr(kex->peer), sshbuf_len(kex->peer),
|
|
server_host_key_blob, sbloblen,
|
|
kex->dh->pub_key,
|
|
dh_server_pub,
|
|
shared_secret,
|
|
hash, &hashlen)) != 0)
|
|
goto out;
|
|
|
|
if ((r = sshkey_verify(server_host_key, signature, slen, hash, hashlen,
|
|
kex->hostkey_alg, ssh->compat)) != 0)
|
|
goto out;
|
|
|
|
/* save session id */
|
|
if (kex->session_id == NULL) {
|
|
kex->session_id_len = hashlen;
|
|
kex->session_id = malloc(kex->session_id_len);
|
|
if (kex->session_id == NULL) {
|
|
r = SSH_ERR_ALLOC_FAIL;
|
|
goto out;
|
|
}
|
|
memcpy(kex->session_id, hash, kex->session_id_len);
|
|
}
|
|
|
|
if ((r = kex_derive_keys_bn(ssh, hash, hashlen, shared_secret)) == 0)
|
|
r = kex_send_newkeys(ssh);
|
|
out:
|
|
explicit_bzero(hash, sizeof(hash));
|
|
DH_free(kex->dh);
|
|
kex->dh = NULL;
|
|
BN_clear_free(dh_server_pub);
|
|
if (kbuf) {
|
|
explicit_bzero(kbuf, klen);
|
|
free(kbuf);
|
|
}
|
|
BN_clear_free(shared_secret);
|
|
sshkey_free(server_host_key);
|
|
free(server_host_key_blob);
|
|
free(signature);
|
|
return r;
|
|
}
|
|
#endif /* WITH_OPENSSL */
|