Commit Graph

4743 Commits

Author SHA1 Message Date
Damien Miller
da380becc6 - OpenBSD CVS Sync
- deraadt@cvs.openbsd.org 2006/03/27 01:21:18
     [xmalloc.c]
     we can do the size & nmemb check before the integer overflow check;
     evol
2006-03-31 23:09:17 +11:00
Damien Miller
b3cdc220c4 - deraadt@cvs.openbsd.org 2006/03/26 01:31:48
[uuencode.c]
     typo
2006-03-26 14:30:33 +11:00
Damien Miller
51096383e9 - djm@cvs.openbsd.org 2006/03/25 22:22:43
[atomicio.h auth-options.h auth.h auth2-gss.c authfd.h authfile.h]
     [bufaux.h buffer.h canohost.h channels.h cipher.h clientloop.h]
     [compat.h compress.h crc32.c crc32.h deattack.h dh.h dispatch.h]
     [dns.c dns.h getput.h groupaccess.h gss-genr.c gss-serv-krb5.c]
     [gss-serv.c hostfile.h includes.h kex.h key.h log.h mac.h match.h]
     [misc.h monitor.h monitor_fdpass.h monitor_mm.h monitor_wrap.h msg.h]
     [myproposal.h packet.h pathnames.h progressmeter.h readconf.h rsa.h]
     [scard.h servconf.h serverloop.h session.h sftp-common.h sftp.h]
     [ssh-gss.h ssh.h ssh1.h ssh2.h sshconnect.h sshlogin.h sshpty.h]
     [ttymodes.h uidswap.h uuencode.h xmalloc.h]
     standardise spacing in $OpenBSD$ tags; requested by deraadt@
2006-03-26 14:30:00 +11:00
Damien Miller
e3b21a5f59 - deraadt@cvs.openbsd.org 2006/03/25 18:58:10
[channels.c]
     delete cast not required
2006-03-26 14:29:06 +11:00
Damien Miller
a0fdce9a47 - deraadt@cvs.openbsd.org 2006/03/25 18:56:55
[bufaux.c channels.c packet.c]
     remove (char *) casts to a function that accepts void * for the arg
2006-03-26 14:28:50 +11:00
Damien Miller
08d61505d7 - deraadt@cvs.openbsd.org 2006/03/25 18:43:30
[channels.c]
     use strtonum() instead of atoi() [limit X screens to 400, sorry]
2006-03-26 14:28:32 +11:00
Damien Miller
1c13bd8d79 - deraadt@cvs.openbsd.org 2006/03/25 18:41:45
[ssh-agent.c]
     mark two more signal handlers ARGSUSED
2006-03-26 14:28:14 +11:00
Damien Miller
5f340065fc - deraadt@cvs.openbsd.org 2006/03/25 18:40:14
[ssh-keygen.c]
     cast strtonum() result to right type
2006-03-26 14:27:57 +11:00
Damien Miller
a1690d08b4 - deraadt@cvs.openbsd.org 2006/03/25 18:36:15
[sshlogin.c sshlogin.h]
     nicer size_t and time_t types
2006-03-26 14:27:35 +11:00
Damien Miller
90fdfaf69c - deraadt@cvs.openbsd.org 2006/03/25 18:30:55
[clientloop.c serverloop.c]
     spacing
2006-03-26 14:25:37 +11:00
Damien Miller
8ba29fe72d - deraadt@cvs.openbsd.org 2006/03/25 18:29:35
[auth-rsa.c authfd.c packet.c]
     needed casts (always will be needed)
2006-03-26 14:25:19 +11:00
Damien Miller
48c4ed2b78 oops, rewrap 2006-03-26 14:25:05 +11:00
Damien Miller
57c30117c1 - djm@cvs.openbsd.org 2006/03/25 13:17:03
[atomicio.c auth-bsdauth.c auth-chall.c auth-options.c auth-passwd.c]
     [auth-rh-rsa.c auth-rhosts.c auth-rsa.c auth-skey.c auth.c auth1.c]
     [auth2-chall.c auth2-hostbased.c auth2-kbdint.c auth2-none.c]
     [auth2-passwd.c auth2-pubkey.c auth2.c authfd.c authfile.c bufaux.c]
     [buffer.c canohost.c channels.c cipher-3des1.c cipher-bf1.c]
     [cipher-ctr.c cipher.c cleanup.c clientloop.c compat.c compress.c]
     [deattack.c dh.c dispatch.c fatal.c groupaccess.c hostfile.c kex.c]
     [kexdh.c kexdhc.c kexdhs.c kexgex.c kexgexc.c kexgexs.c key.c log.c]
     [mac.c match.c md-sha256.c misc.c monitor.c monitor_fdpass.c]
     [monitor_mm.c monitor_wrap.c msg.c nchan.c packet.c progressmeter.c]
     [readconf.c readpass.c rsa.c scard.c scp.c servconf.c serverloop.c]
     [session.c sftp-client.c sftp-common.c sftp-glob.c sftp-server.c]
     [sftp.c ssh-add.c ssh-agent.c ssh-dss.c ssh-keygen.c ssh-keyscan.c]
     [ssh-keysign.c ssh-rsa.c ssh.c sshconnect.c sshconnect1.c]
     [sshconnect2.c sshd.c sshlogin.c sshpty.c sshtty.c ttymodes.c]
     [uidswap.c uuencode.c xmalloc.c]
     Put $OpenBSD$ tags back (as comments) to replace the RCSID()s that
     Theo nuked - our scripts to sync -portable need them in the files
2006-03-26 14:24:48 +11:00
Damien Miller
55b04f1d77 - djm@cvs.openbsd.org 2006/03/25 01:30:23
[sftp.c]
     "abormally" is a perfectly cromulent word, but "abnormally" is better
2006-03-26 14:23:17 +11:00
Damien Miller
36812092ec - djm@cvs.openbsd.org 2006/03/25 01:13:23
[buffer.c channels.c deattack.c misc.c scp.c session.c sftp-client.c]
     [sftp-server.c ssh-agent.c ssh-rsa.c xmalloc.c xmalloc.h auth-pam.c]
     [uidswap.c]
     change OpenSSH's xrealloc() function from being xrealloc(p, new_size)
     to xrealloc(p, new_nmemb, new_itemsize).

     realloc is particularly prone to integer overflows because it is
     almost always allocating "n * size" bytes, so this is a far safer
     API; ok deraadt@
2006-03-26 14:22:47 +11:00
Damien Miller
07d86bec5e - djm@cvs.openbsd.org 2006/03/25 00:05:41
[auth-bsdauth.c auth-skey.c auth.c auth2-chall.c channels.c]
     [clientloop.c deattack.c gss-genr.c kex.c key.c misc.c moduli.c]
     [monitor.c monitor_wrap.c packet.c scard.c sftp-server.c ssh-agent.c]
     [ssh-keyscan.c ssh.c sshconnect.c sshconnect2.c sshd.c uuencode.c]
     [xmalloc.c xmalloc.h]
     introduce xcalloc() and xasprintf() failure-checked allocations
     functions and use them throughout openssh

     xcalloc is particularly important because malloc(nmemb * size) is a
     dangerous idiom (subject to integer overflow) and it is time for it
     to die

     feedback and ok deraadt@
2006-03-26 14:19:21 +11:00
Damien Miller
7cd4579eb3 - djm@cvs.openbsd.org 2006/03/22 21:27:15
[deattack.c deattack.h packet.c]
     remove IV support from the CRC attack detector, OpenSSH has never used
     it - it only applied to IDEA-CFB, which we don't support.
     prompted by NetBSD Coverity report via elad AT netbsd.org;
     feedback markus@ "nuke it" deraadt@
2006-03-26 14:11:39 +11:00
Damien Miller
a5a2859275 - deraadt@cvs.openbsd.org 2006/03/20 21:11:53
[ttymodes.c]
     spacing
2006-03-26 14:10:34 +11:00
Damien Miller
4f7becb44f - deraadt@cvs.openbsd.org 2006/03/20 18:48:34
[channels.c fatal.c kex.c packet.c serverloop.c]
     spacing
2006-03-26 14:10:14 +11:00
Damien Miller
1d2b6706ba - deraadt@cvs.openbsd.org 2006/03/20 18:42:27
[canohost.c match.c ssh.c sshconnect.c]
     be strict with tolower() casting
2006-03-26 14:09:54 +11:00
Damien Miller
1ff7c642ee - deraadt@cvs.openbsd.org 2006/03/20 18:41:43
[dns.c]
     cast xstrdup to propert u_char *
2006-03-26 14:09:09 +11:00
Damien Miller
4ae97f1885 - deraadt@cvs.openbsd.org 2006/03/20 18:35:12
[channels.c]
     x11_fake_data is only ever used as u_char *
2006-03-26 14:08:10 +11:00
Damien Miller
9f3bd53acd - deraadt@cvs.openbsd.org 2006/03/20 18:27:50
[monitor.c]
     spacing
2006-03-26 14:07:52 +11:00
Damien Miller
9096740f6c - deraadt@cvs.openbsd.org 2006/03/20 18:26:55
[channels.c monitor.c session.c session.h ssh-agent.c ssh-keygen.c]
     [ssh-rsa.c ssh.c sshlogin.c]
     annoying spacing fixes getting in the way of real diffs
2006-03-26 14:07:26 +11:00
Damien Miller
91d4b12fcb - deraadt@cvs.openbsd.org 2006/03/20 18:17:20
[auth1.c auth2.c sshd.c]
     sprinkle some ARGSUSED for table driven functions (which sometimes
     must ignore their args)
2006-03-26 14:05:20 +11:00
Damien Miller
1b81a49f86 rewrap 2006-03-26 14:05:02 +11:00
Damien Miller
71a7367130 - deraadt@cvs.openbsd.org 2006/03/20 18:14:02
[channels.c clientloop.c monitor_wrap.c monitor_wrap.h serverloop.c]
     [ssh.c sshpty.c sshpty.h]
     sprinkle u_int throughout pty subsystem, ok markus
2006-03-26 14:04:36 +11:00
Damien Miller
6d39bcf898 - deraadt@cvs.openbsd.org 2006/03/20 17:17:23
[ssh-rsa.c]
     in a switch (), break after return or goto is stupid
2006-03-26 14:03:21 +11:00
Damien Miller
bbaad7772a - deraadt@cvs.openbsd.org 2006/03/20 17:13:16
[key.c]
     djm did a typo
2006-03-26 14:03:03 +11:00
Damien Miller
69b7203e6f - deraadt@cvs.openbsd.org 2006/03/20 17:10:19
[auth.c key.c misc.c packet.c ssh-add.c]
     in a switch (), break after return or goto is stupid
2006-03-26 14:02:35 +11:00
Damien Miller
429fcc23db - djm@cvs.openbsd.org 2006/03/20 11:38:46
[key.c]
     (really) last of the Coverity diffs: avoid possible NULL deref in
     key_free. via elad AT netbsd.org; markus@ ok
2006-03-26 14:02:16 +11:00
Damien Miller
96937bd914 - djm@cvs.openbsd.org 2006/03/20 04:09:44
[monitor.c]
     memory leaks detected by Coverity via elad AT netbsd.org;
     deraadt@ ok
     that should be all of them now
2006-03-26 14:01:54 +11:00
Damien Miller
3305f5591f - deraadt@cvs.openbsd.org 2006/03/19 18:59:09
[authfile.c]
     whoever thought that break after return was a good idea needs to
     get their head examimed
2006-03-26 14:00:31 +11:00
Damien Miller
4662d3492f - deraadt@cvs.openbsd.org 2006/03/19 18:59:30
[ssh.c]
     spacing
2006-03-26 13:59:59 +11:00
Damien Miller
3bbaba6075 - deraadt@cvs.openbsd.org 2006/03/19 18:59:49
[ssh-keyscan.c]
     please lint
2006-03-26 13:59:38 +11:00
Damien Miller
f0b15dfc52 - deraadt@cvs.openbsd.org 2006/03/19 18:56:41
[clientloop.c progressmeter.c serverloop.c sshd.c]
     ARGSUSED for signal handlers
2006-03-26 13:59:20 +11:00
Damien Miller
c91e556d8a - deraadt@cvs.openbsd.org 2006/03/19 18:53:12
[kex.c kex.h monitor.c myproposal.h session.c]
     spacing
2006-03-26 13:58:55 +11:00
Damien Miller
d62f2ca376 - deraadt@cvs.openbsd.org 2006/03/19 18:52:11
[auth1.c authfd.c channels.c]
     spacing
2006-03-26 13:57:41 +11:00
Damien Miller
4ca108d192 id sync 2006-03-26 13:57:07 +11:00
Damien Miller
78f16cb07b - dtucker@cvs.openbsd.org 2006/03/19 11:51:52
[servconf.c]
     Correct strdelim null test; ok djm@
2006-03-26 13:54:37 +11:00
Damien Miller
5790b5910b - djm@cvs.openbsd.org 2006/03/19 07:41:30
[sshconnect2.c]
     memory leaks detected by Coverity via elad AT netbsd.org;
     deraadt@ ok
2006-03-26 13:54:03 +11:00
Damien Miller
928b23684a - djm@cvs.openbsd.org 2006/03/19 02:24:05
[dh.c readconf.c servconf.c]
     potential NULL pointer dereferences detected by Coverity
     via elad AT netbsd.org; ok deraadt@
2006-03-26 13:53:32 +11:00
Damien Miller
6db780e259 - djm@cvs.openbsd.org 2006/03/19 02:23:26
[hostfile.c]
     FILE* leak detected by Coverity via elad AT netbsd.org;
     ok deraadt@
2006-03-26 13:52:20 +11:00
Damien Miller
e0b90a6766 - djm@cvs.openbsd.org 2006/03/19 02:22:56
[sftp.c]
     more memory leaks detected by Coverity via elad AT netbsd.org;
     deraadt@ ok
2006-03-26 13:51:44 +11:00
Damien Miller
6f98a1fea7 - djm@cvs.openbsd.org 2006/03/19 02:22:32
[serverloop.c]
     memory leaks detected by Coverity via elad AT netbsd.org;
     ok deraadt@ dtucker@
2006-03-26 13:51:08 +11:00
Damien Miller
304a940889 - djm@cvs.openbsd.org 2006/03/17 22:31:11
[authfd.c]
     unreachanble statement, found by lint
2006-03-26 13:50:37 +11:00
Damien Miller
5b83232b48 - djm@cvs.openbsd.org 2006/03/17 22:31:50
[authfd.c]
     another unreachable found by lint
2006-03-26 13:50:14 +11:00
Damien Miller
745570cd79 - biorn@cvs.openbsd.org 2006/03/16 10:31:45
[scp.c]
     Try to display errormessage even if remout == -1
     ok djm@, markus@
2006-03-26 13:49:43 +11:00
Damien Miller
cb314828eb - OpenBSD CVS Sync
- jakob@cvs.openbsd.org 2006/03/15 08:46:44
     [ssh-keygen.c]
     if no key file are given when printing the DNS host record, use the
     host key file(s) as default. ok djm@
2006-03-26 13:48:01 +11:00
Damien Miller
2dbbf8e9fc [deattack.c deattack.h]
remove IV support from the CRC attack detector, OpenSSH has never used
     it - it only applied to IDEA-CFB, which we don't support.
     prompted by NetBSD Coverity report via elad AT netbsd.org;
     feedback markus@ "nuke it" deraadt@
2006-03-26 00:11:46 +11:00