RepoMirrors/openssh
1
0
Fork 0
mirror of git://anongit.mindrot.org/openssh.git synced 2025-01-09 11:09:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

- (dtucker) [auth-krb5.c] There's no guarantee that snprintf will set errno

Browse Source 
in the case where the buffer is insufficient, so always return ENOMEM.
   Also pointed out by sxw at inf.ed.ac.uk.
This commit is contained in:
Darren Tucker 2005-07-07 20:09:35 +10:00
parent a916d143a1
commit a83f2612c2
2 changed files with 9 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ChangeLog
View File

@ -1,7 +1,11 @@
20050707 20050707
- [auth-krb5.c auth.h gss-serv-krb5.c] Move KRB5CCNAME generation for the MIT - dtucker [auth-krb5.c auth.h gss-serv-krb5.c] Move KRB5CCNAME generation for
Kerberos code path into a common function and expand mkstemp template to be the MIT Kerberos code path into a common function and expand mkstemp
consistent with the rest of OpenSSH. From sxw at inf.ed.ac.uk, ok djm@ template to be consistent with the rest of OpenSSH. From sxw at
inf.ed.ac.uk, ok djm@
- (dtucker) [auth-krb5.c] There's no guarantee that snprintf will set errno
in the case where the buffer is insufficient, so always return ENOMEM.
Also pointed out by sxw at inf.ed.ac.uk.
20050706 20050706
- (djm) OpenBSD CVS Sync - (djm) OpenBSD CVS Sync
@ -2787,4 +2791,4 @@
- (djm) Trim deprecated options from INSTALL. Mention UsePAM - (djm) Trim deprecated options from INSTALL. Mention UsePAM
- (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu - (djm) Fix quote handling in sftp; Patch from admorten AT umich.edu
$Id: ChangeLog,v 1.3836 2005/07/07 01:50:20 dtucker Exp $ $Id: ChangeLog,v 1.3837 2005/07/07 10:09:35 dtucker Exp $

2
auth-krb5.c
View File

@ -222,7 +222,7 @@ ssh_krb5_cc_gen(krb5_context ctx, krb5_ccache *ccache) {
ret = snprintf(ccname, sizeof(ccname), ret = snprintf(ccname, sizeof(ccname),
"FILE:/tmp/krb5cc_%d_XXXXXXXXXX", geteuid()); "FILE:/tmp/krb5cc_%d_XXXXXXXXXX", geteuid());
if (ret == -1 || ret >= sizeof(ccname)) if (ret == -1 || ret >= sizeof(ccname))
return errno; return ENOMEM;
old_umask = umask(0177); old_umask = umask(0177);
tmpfd = mkstemp(ccname + strlen("FILE:")); tmpfd = mkstemp(ccname + strlen("FILE:"));