From 4cbc4a722873d9b68cb5496304dc050d7168df78 Mon Sep 17 00:00:00 2001 From: "djm@openbsd.org" Date: Wed, 31 Mar 2021 21:59:26 +0000 Subject: [PATCH] upstream: cannot effectively test posix-rename extension after changes in feature advertisment. OpenBSD-Regress-ID: 5e390bf88d379162aaa81b60ed86b34cb0c54d29 --- regress/sftp-perm.sh | 18 ++++++++++-------- 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/regress/sftp-perm.sh b/regress/sftp-perm.sh index 304ca0ac5..de96a14da 100644 --- a/regress/sftp-perm.sh +++ b/regress/sftp-perm.sh @@ -1,4 +1,4 @@ -# $OpenBSD: sftp-perm.sh,v 1.2 2013/10/17 22:00:18 djm Exp $ +# $OpenBSD: sftp-perm.sh,v 1.3 2021/03/31 21:59:26 djm Exp $ # Placed in the Public Domain. tid="sftp permissions" @@ -220,13 +220,15 @@ perm_test \ "test ! -d ${COPY}.dd" \ "test -d ${COPY}.dd" -perm_test \ - "posix-rename" \ - "realpath,stat,lstat" \ - "rename $COPY ${COPY}.1" \ - "touch $COPY" \ - "test -f ${COPY}.1 -a ! -f $COPY" \ - "test -f $COPY -a ! -f ${COPY}.1" +# Can't readily test this because the client falls back to traditional rename. +# XXX maybe there is a behaviorial difference we can test for? +#perm_test \ +# "posix-rename" \ +# "realpath,stat,lstat" \ +# "rename $COPY ${COPY}.1" \ +# "touch $COPY" \ +# "test -f ${COPY}.1 -a ! -f $COPY" \ +# "test -f $COPY -a ! -f ${COPY}.1" perm_test \ "rename" \