From 26e0bcf766fadb4a44fb6199386fb1dcab65ad00 Mon Sep 17 00:00:00 2001 From: "djm@openbsd.org" Date: Mon, 30 Mar 2015 00:00:29 +0000 Subject: [PATCH] upstream commit fix uninitialised memory read when parsing a config file consisting of a single nul byte. Found by hanno AT hboeck.de using AFL; ok dtucker --- readconf.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/readconf.c b/readconf.c index 42a2961fa..9e15f27bb 100644 --- a/readconf.c +++ b/readconf.c @@ -1,4 +1,4 @@ -/* $OpenBSD: readconf.c,v 1.232 2015/02/16 22:13:32 djm Exp $ */ +/* $OpenBSD: readconf.c,v 1.233 2015/03/30 00:00:29 djm Exp $ */ /* * Author: Tatu Ylonen * Copyright (c) 1995 Tatu Ylonen , Espoo, Finland @@ -763,7 +763,9 @@ process_config_line(Options *options, struct passwd *pw, const char *host, } /* Strip trailing whitespace */ - for (len = strlen(line) - 1; len > 0; len--) { + if ((len = strlen(line)) == 0) + return 0; + for (len--; len > 0; len--) { if (strchr(WHITESPACE, line[len]) == NULL) break; line[len] = '\0';