- djm@cvs.openbsd.org 2011/02/04 00:44:21

[key.c]
     fix uninitialised nonce variable; reported by Mateusz Kocielski
This commit is contained in:
Damien Miller 2011-02-04 11:47:01 +11:00
parent b407dd8d05
commit 0a5f0129a3
2 changed files with 6 additions and 4 deletions

View File

@ -3,6 +3,9 @@
- djm@cvs.openbsd.org 2011/01/31 21:42:15 - djm@cvs.openbsd.org 2011/01/31 21:42:15
[PROTOCOL.mux] [PROTOCOL.mux]
cut'n'pasto; from bert.wesarg AT googlemail.com cut'n'pasto; from bert.wesarg AT googlemail.com
- djm@cvs.openbsd.org 2011/02/04 00:44:21
[key.c]
fix uninitialised nonce variable; reported by Mateusz Kocielski
20110128 20110128
- (djm) [openbsd-compat/port-linux.c] Check whether SELinux is enabled - (djm) [openbsd-compat/port-linux.c] Check whether SELinux is enabled

7
key.c
View File

@ -1,4 +1,4 @@
/* $OpenBSD: key.c,v 1.95 2010/11/10 01:33:07 djm Exp $ */ /* $OpenBSD: key.c,v 1.96 2011/02/04 00:44:21 djm Exp $ */
/* /*
* read_bignum(): * read_bignum():
* Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland * Copyright (c) 1995 Tatu Ylonen <ylo@cs.hut.fi>, Espoo, Finland
@ -1886,10 +1886,9 @@ key_certify(Key *k, Key *ca)
buffer_put_cstring(&k->cert->certblob, key_ssh_name(k)); buffer_put_cstring(&k->cert->certblob, key_ssh_name(k));
/* -v01 certs put nonce first */ /* -v01 certs put nonce first */
if (!key_cert_is_legacy(k)) { arc4random_buf(&nonce, sizeof(nonce));
arc4random_buf(&nonce, sizeof(nonce)); if (!key_cert_is_legacy(k))
buffer_put_string(&k->cert->certblob, nonce, sizeof(nonce)); buffer_put_string(&k->cert->certblob, nonce, sizeof(nonce));
}
switch (k->type) { switch (k->type) {
case KEY_DSA_CERT_V00: case KEY_DSA_CERT_V00: