RepoMirrors/nvchecker
1
0
Fork 0
mirror of https://github.com/lilydjwg/nvchecker synced 2025-02-26 23:41:05 +00:00
Code Issues Packages Projects Releases Wiki Activity

Allow empty to_pattern

Browse Source 
It's useful to have a partial match pattern to be replaced by an empty
string, like stripping a suffix. Let's allow it as "not to_pattern" will
reject this.
This commit is contained in:
Felix Yan 2020-10-02 04:39:57 +08:00
parent a78c06163c
commit 071b57c580
No known key found for this signature in database
GPG Key ID: 786C63F330D7CB92
2 changed files with 9 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
nvchecker/core.py
View File

@ -250,7 +250,7 @@ def substitute_version(
from_pattern = conf.get('from_pattern')
if from_pattern:
to_pattern = conf.get('to_pattern')
if not to_pattern:
if to_pattern is None:
raise ValueError("from_pattern exists but to_pattern doesn't")
return re.sub(from_pattern, to_pattern, version)

8
tests/test_substitute.py
View File

@ -34,6 +34,14 @@ async def test_substitute_regex_missing_ok(get_version):
"to_pattern": r"r\1.\2",
}) == "r15"
async def test_substitute_regex_empty_to_pattern(get_version):
assert await get_version("example", {
"source": "manual",
"manual": "15-debian",
"from_pattern": r"-\w+$",
"to_pattern": r"",
}) == "15"
async def test_substitute_prefix_has_higher_priority(get_version):
assert await get_version("example", {
"source": "manual",