From e6ffeb490740cb3dffc8a601c3a9d9d9a62dbe4e Mon Sep 17 00:00:00 2001 From: Matteo Bigoi Date: Wed, 21 Oct 2015 15:38:26 +0000 Subject: [PATCH] Reduce nesting in sanity check --- collector/loadavg_linux.go | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) diff --git a/collector/loadavg_linux.go b/collector/loadavg_linux.go index 162057ad..ccd2e372 100644 --- a/collector/loadavg_linux.go +++ b/collector/loadavg_linux.go @@ -86,15 +86,14 @@ func getLoad() (loads []float64, err error) { func parseLoad(data string) (loads []float64, err error) { loads = make([]float64, 3) parts := strings.Fields(data) - if len(parts) >= 3 { - for i, load := range parts[0:3] { - loads[i], err = strconv.ParseFloat(load, 64) - if err != nil { - return nil, fmt.Errorf("could not parse load '%s': %s", load, err) - } - } - } else { + if len(parts) < 3 { return nil, fmt.Errorf("unexpected content in %s", procFilePath("loadavg")) } + for i, load := range parts[0:3] { + loads[i], err = strconv.ParseFloat(load, 64) + if err != nil { + return nil, fmt.Errorf("could not parse load '%s': %s", load, err) + } + } return loads, nil }