From dcfd6104332b22d3de1afa5425b6316b7a2952c6 Mon Sep 17 00:00:00 2001 From: Johannes 'fish' Ziemke Date: Sat, 15 Feb 2020 11:39:45 +0100 Subject: [PATCH] systemd: Clarify private flag description (#1587) This requires root, so it shouldn't be used. This closes #1246 Signed-off-by: Johannes 'fish' Ziemke --- collector/systemd_linux.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/collector/systemd_linux.go b/collector/systemd_linux.go index 3c55f4db..db659bfe 100644 --- a/collector/systemd_linux.go +++ b/collector/systemd_linux.go @@ -41,7 +41,7 @@ const ( var ( unitWhitelist = kingpin.Flag("collector.systemd.unit-whitelist", "Regexp of systemd units to whitelist. Units must both match whitelist and not match blacklist to be included.").Default(".+").String() unitBlacklist = kingpin.Flag("collector.systemd.unit-blacklist", "Regexp of systemd units to blacklist. Units must both match whitelist and not match blacklist to be included.").Default(".+\\.(automount|device|mount|scope|slice)").String() - systemdPrivate = kingpin.Flag("collector.systemd.private", "Establish a private, direct connection to systemd without dbus.").Bool() + systemdPrivate = kingpin.Flag("collector.systemd.private", "Establish a private, direct connection to systemd without dbus (Strongly discouraged since it requires root. For testing purposes only).").Hidden().Bool() enableTaskMetrics = kingpin.Flag("collector.systemd.enable-task-metrics", "Enables service unit tasks metrics unit_tasks_current and unit_tasks_max").Bool() enableRestartsMetrics = kingpin.Flag("collector.systemd.enable-restarts-metrics", "Enables service unit metric service_restart_total").Bool() enableStartTimeMetrics = kingpin.Flag("collector.systemd.enable-start-time-metrics", "Enables service unit metric unit_start_time_seconds").Bool()